Fix BasicGoServer Docker build by running go mod tidy#2149
Fix BasicGoServer Docker build by running go mod tidy#2149LoopedBard3 wants to merge 1 commit intoaspnet:mainfrom
Conversation
Update go.sum to match go.mod dependencies (golang.org/x/net v0.33.0 -> v0.38.0) and remove unused github.com/golang/glog dependency.
There was a problem hiding this comment.
Pull request overview
Updates the BasicGoServer Go module metadata to resolve Docker/build issues caused by dependency metadata drift, aligning go.sum with go.mod after a go mod tidy.
Changes:
- Updated
golang.org/x/net(and related indirect deps) checksums ingo.sumto matchgo.mod. - Removed the unused
github.com/golang/glogdependency fromgo.mod. - Bumped the module
godirective togo 1.23.0.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BenchmarksApps/Grpc/BasicGoServer/go.sum | Refreshes dependency checksums to align with updated indirect dependency versions. |
| src/BenchmarksApps/Grpc/BasicGoServer/go.mod | Removes unused glog, updates indirect deps, and updates the module Go toolchain version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/grpc/grpc-dotnet | ||
|
|
||
| go 1.21 | ||
| go 1.23.0 |
There was a problem hiding this comment.
The go directive was bumped from 1.21 to 1.23.0, which makes this module require a newer toolchain than the other Go benchmark apps in this repo (e.g., GoServer/GoClient still use go 1.21). If this change is unintentional from running go mod tidy, consider reverting it back to the repo’s baseline Go version (and matching the existing go 1.xx format) to avoid breaking builds/environments pinned to 1.21.
Update go.sum to match go.mod dependencies (golang.org/x/net v0.33.0 -> v0.38.0) and remove unused github.com/golang/glog dependency.
This fixes the current error causing failures for the test that uses this.
Failure: