Skip to content

Fix BasicGoServer Docker build by running go mod tidy#2149

Open
LoopedBard3 wants to merge 1 commit intoaspnet:mainfrom
LoopedBard3:FixFailingGolangGRPC
Open

Fix BasicGoServer Docker build by running go mod tidy#2149
LoopedBard3 wants to merge 1 commit intoaspnet:mainfrom
LoopedBard3:FixFailingGolangGRPC

Conversation

@LoopedBard3
Copy link
Contributor

@LoopedBard3 LoopedBard3 commented Feb 6, 2026

Update go.sum to match go.mod dependencies (golang.org/x/net v0.33.0 -> v0.38.0) and remove unused github.com/golang/glog dependency.

This fixes the current error causing failures for the test that uses this.
Failure:

ERROR [build-env 4/4] RUN go build -o todo                                                                                                                                                                                                         1.5s
  ------
   > [build-env 4/4] RUN go build -o todo:
  0.364 go: downloading google.golang.org/grpc v1.64.1
  0.366 go: downloading google.golang.org/protobuf v1.34.1
  0.957 go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240521202816-d264139d666e
  0.957 go: downloading golang.org/x/sys v0.28.0
  1.349 /go/pkg/mod/google.golang.org/grpc@v1.64.1/trace_withtrace.go:26:2: missing go.sum entry for module providing package golang.org/x/net/trace (imported by google.golang.org/grpc); to add:
  1.349   go get google.golang.org/grpc@v1.64.1
  1.349 /go/pkg/mod/google.golang.org/grpc@v1.64.1/internal/transport/controlbuf.go:31:2: missing go.sum entry for module providing package golang.org/x/net/http2 (imported by google.golang.org/grpc/internal/transport); to add:
  1.349   go get google.golang.org/grpc/internal/transport@v1.64.1
  1.349 /go/pkg/mod/google.golang.org/grpc@v1.64.1/internal/transport/controlbuf.go:32:2: missing go.sum entry for module providing package golang.org/x/net/http2/hpack (imported by google.golang.org/grpc/internal/transport); to add:
  1.349   go get google.golang.org/grpc/internal/transport@v1.64.1

Update go.sum to match go.mod dependencies (golang.org/x/net
v0.33.0 -> v0.38.0) and remove unused github.com/golang/glog
dependency.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the BasicGoServer Go module metadata to resolve Docker/build issues caused by dependency metadata drift, aligning go.sum with go.mod after a go mod tidy.

Changes:

  • Updated golang.org/x/net (and related indirect deps) checksums in go.sum to match go.mod.
  • Removed the unused github.com/golang/glog dependency from go.mod.
  • Bumped the module go directive to go 1.23.0.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/BenchmarksApps/Grpc/BasicGoServer/go.sum Refreshes dependency checksums to align with updated indirect dependency versions.
src/BenchmarksApps/Grpc/BasicGoServer/go.mod Removes unused glog, updates indirect deps, and updates the module Go toolchain version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

module github.com/grpc/grpc-dotnet

go 1.21
go 1.23.0
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go directive was bumped from 1.21 to 1.23.0, which makes this module require a newer toolchain than the other Go benchmark apps in this repo (e.g., GoServer/GoClient still use go 1.21). If this change is unintentional from running go mod tidy, consider reverting it back to the repo’s baseline Go version (and matching the existing go 1.xx format) to avoid breaking builds/environments pinned to 1.21.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant