Skip to content

Conversation

@martincostello
Copy link
Member

Remove deprecated yeoman-assert package whose functionality is now part of yeoman-test.

Remove deprecated `yeoman-assert` package whose functionality is now part of `yeoman-test`.
Replace `yeoman-test:assert.strictEqual()` with `assert:asserts.equal()`.
@martincostello martincostello marked this pull request as ready for review December 1, 2025 10:21
Copilot AI review requested due to automatic review settings December 1, 2025 10:21
@martincostello martincostello merged commit 9fca08b into dev Dec 1, 2025
1 check passed
@martincostello martincostello deleted the remove-deprecated-package branch December 1, 2025 10:21
Copilot finished reviewing on behalf of martincostello December 1, 2025 10:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated yeoman-assert package from the project's dependencies, migrating to Node.js's built-in assert module for test assertions. The yeoman-assert package has been deprecated as its functionality has been integrated into yeoman-test.

Key Changes:

  • Removed yeoman-assert from package.json and package-lock.json dependencies
  • Updated imports in test-app.js to use Node.js built-in assert module
  • Migrated three assert.strictEqual() calls to use the standard assert module

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.

File Description
package.json Removed deprecated yeoman-assert dependency from devDependencies
package-lock.json Removed yeoman-assert package entry and metadata from lockfile
test/test-app.js Updated imports and migrated assertion calls from yeoman-assert to Node.js assert
Comments suppressed due to low confidence (1)

test/test-app.js:3

  • Unused import assert.
import assert from 'yeoman-test';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants