Skip to content

Remove description root property, and rename specification_version and specification_source #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antpb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove description root property, and rename specification_version and specification_source #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e1f7a8
removes description as it should be in sections and renames specifica…
antpb Oct 25, 2024
23efb70
add banners in example and fix constant
antpb Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions plugins/specification/1.0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ This specification allows for the standardization of metadata for WordPress plug
"screenshots": ""
},
"short_description": "A WordPress plugin for drag and drop 3D content creation compatible with most XR devices.",
"description": "A WordPress plugin for publishing XR content with support for WebXR and popular glTF Extensions.",
"download_link": "https://updater.sxp.digital/xr-publisher.zip",
"screenshots": [],
"tags": {
Expand Down Expand Up @@ -87,8 +86,8 @@ This specification allows for the standardization of metadata for WordPress plug
"preview_link": "https://xrpublisher.com/demo",
"repository_url": "https://github.com/antpb/xr-publisher",
"spec_meta": {
"specification-version": "1.0",
"specification-source": "aspiprepress"
"specification_version": "1.0",
"specification_source": "aspiprepress"
}
}
```
Expand Down
9 changes: 6 additions & 3 deletions plugins/specification/1.0/examples/full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,16 @@
"screenshots": ""
},
"short_description": "A WordPress plugin for drag and drop 3D content creation compatible with most XR devices.",
"description": "A WordPress plugin for publishing XR content with support for WebXR and popular glTF Extensions.",
"download_link": "https://updater.sxp.digital/xr-publisher.zip",
"screenshots": [],
"tags": {
"tag1": "metaverse",
"tag2": "virtual reality"
},
"banners": {
"high": "https://pub-2ef6bc2ae372488daf94a858e2b752ac.r2.dev/antpb/xr-chess-block/banner-1500x620.jpg",
"low": "https://pub-2ef6bc2ae372488daf94a858e2b752ac.r2.dev/antpb/xr-chess-block/banner-1500x620.jpg"
},
"versions": {
"2.0-alpha": "https://updater.sxp.digital/xr-publisher.zip"
},
Expand All @@ -65,7 +68,7 @@
"preview_link": "https://xrpublisher.com/demo",
"repository_url": "https://github.com/antpb/xr-publisher",
"spec_meta": {
"specification-version": "1.0",
"specification-source": "aspiprepress"
"specification_version": "1.0",
"specification_source": "aspirepress"
}
}
12 changes: 9 additions & 3 deletions plugins/specification/1.0/examples/minimal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@
"last_updated": "2024-10-09 12:00pm GMT",
"added": "2024-10-09",
"short_description": "A WordPress plugin for drag and drop 3D content creation compatible with most XR devices.",
"description": "A WordPress plugin for publishing XR content with support for WebXR and popular glTF Extensions.",
"sections": {
"description": "A WordPress plugin for publishing XR content with support for WebXR and popular glTF Extensions.",
"installation": "",
"changelog": "",
"faq": "",
"screenshots": ""
},
"download_link": "https://updater.sxp.digital/xr-publisher.zip",
"spec_meta": {
"specification-version": "1.0",
"specification-source": "aspiprepress"
"specification_version": "1.0",
"specification_source": "aspiprepress"
}
}
18 changes: 7 additions & 11 deletions plugins/specification/1.0/schema/plugin.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@
"type": "string",
"maxLength": 150
},
"description": {
"type": "string",
"contentMediaType": "text/html"
},
"download_link": {
"$ref": "#/$defs/uriString"
},
Expand Down Expand Up @@ -242,19 +238,19 @@
"spec_meta": {
"type": "object",
"properties": {
"specification-version": {
"specification_version": {
"type": "string",
"pattern": "^\\d+\\.\\d+(\\.\\d+)?$",
"default": "1.0"
},
"specification-source": {
"specification_source": {
"type": "string",
"const": "aspiprepress"
"const": "aspirepress"
}
},
"required": [
"specification-version",
"specification-source"
"specification_version",
"specification_source"
],
"additionalProperties": false
}
Expand All @@ -270,8 +266,8 @@
"last_updated",
"added",
"short_description",
"description",
"download_link"
"download_link",
"sections"
],
"additionalProperties": false
}
3 changes: 3 additions & 0 deletions plugins/specification/1.0/schema/plugin.sections.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@
"contentMediaType": "text/html"
}
},
"required": [
"description"
],
"additionalProperties": false
}