bump rusty-kaspa to upstream master, fix clippy#6
Merged
Conversation
Switch the kaspa-* git deps from aspectron/pnn-v1 to kaspanet/master. Box the wrpc client error variant to silence result_large_err clippy warnings (the inner error is ~144 bytes), and silence dead_code on the unused TransportTemplate struct and ClientT::trigger_abort default method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kaspa-consensus-core,kaspa-rpc-core,kaspa-utils,kaspa-wrpc-clientgit deps fromaspectron/rusty-kaspa#pnn-v1tokaspanet/rusty-kaspa#master.Error::KaspaRpcso theErrvariant is no longer ~144 bytes; clears allresult_large_errclippy warnings (manualFromimpl preserves?ergonomics).#[allow(dead_code)]onTransportTemplateandClientT::trigger_abortto silence remaining warnings.