perf: migrate bash launcher to hermetic-build

.bazelrc

@@ -1,5 +1,10 @@
 import %workspace%/bazel/defaults.bazelrc
 
+# TODO: re-enable once https://github.com/hermeticbuild/hermetic-launcher/pull/34
+# lands — adds the missing toolchain= arg to hermetic_launcher's
+# _compile_stub ctx.actions.run, which currently breaks under this flag.
+common --noincompatible_auto_exec_groups
+
 common --test_output=errors
 common --incompatible_disallow_empty_glob=False
 

MODULE.bazel

@@ -23,6 +23,7 @@ bazel_dep(name = "rules_python", version = "1.0.0")
 bazel_dep(name = "rules_shell", version = "0.6.1")
 bazel_dep(name = "tar.bzl", version = "0.10.1")
 bazel_dep(name = "with_cfg.bzl", version = "0.14.6")
+bazel_dep(name = "hermetic_launcher", version = "0.0.8")
 
 bazel_lib_toolchains = use_extension("@tar.bzl//tar:extensions.bzl", "toolchains")
 use_repo(bazel_lib_toolchains, "bsd_tar_toolchains")

py/private/py_pex_binary.bzl

@@ -18,8 +18,10 @@ py_pex_binary(
 ```
 """
 
+load("@bazel_lib//lib:paths.bzl", "to_rlocation_path")
 load("@rules_python//python:defs.bzl", "PyInfo")
 load("//py/private:py_semantics.bzl", _py_semantics = "semantics")
+load("//py/private/py_venv:types.bzl", "PyExecutableInfo")
 load("//py/private/toolchain:types.bzl", "PY_TOOLCHAIN")
 
 def _runfiles_path(file, workspace):
@@ -106,7 +108,7 @@ def _py_python_pex_impl(ctx):
         # this is needed to allow passing a lambda (with workspace_name) to map_each
         allow_closure = True,
     )
-    args.add(binary[DefaultInfo].files_to_run.executable, format = "--executable=%s")
+    args.add(to_rlocation_path(ctx, binary[PyExecutableInfo].entrypoint), format = "--entrypoint=%s")
     args.add(ctx.attr.python_shebang, format = "--python-shebang=%s")
 
     if ctx.attr.inherit_path != "":
@@ -137,7 +139,7 @@ def _py_python_pex_impl(ctx):
     ]
 
 _attrs = dict({
-    "binary": attr.label(executable = True, cfg = "target", mandatory = True, doc = "A py_binary target"),
+    "binary": attr.label(executable = True, cfg = "target", mandatory = True, providers = [PyExecutableInfo], doc = "A py_binary target"),
     "inject_env": attr.string_dict(
         doc = "Environment variables to set when running the pex binary.",
         default = {},

py/private/py_venv/BUILD.bazel

@@ -7,7 +7,6 @@ package(default_visibility = ["//py:__subpackages__"])
 exports_files([
     "_virtualenv.py",
     "link.py",
-    "run.tmpl.sh",
     "venv.tmpl.sh",
     "venv_activate.tmpl.sh",
 ])
@@ -57,6 +56,7 @@ bzl_library(
         "//py/private:py_semantics",
         "@bazel_lib//lib:expand_make_vars",
         "@bazel_lib//lib:paths",
+        "@hermetic_launcher//launcher:lib_bzl",
     ],
 )
 

py/private/py_venv/_virtualenv.py

@@ -3,6 +3,14 @@
 import os
 import sys
 
+# Make wheel-declared console scripts reachable via `subprocess.run("name", ...)`.
+# Use dirname(sys.executable) so this works on Windows too, where the scripts
+# dir is `Scripts/` rather than `bin/`.
+_venv_bin = os.path.dirname(sys.executable)
+if _venv_bin not in os.environ.get("PATH", "").split(os.pathsep):
+    os.environ["PATH"] = _venv_bin + os.pathsep + os.environ.get("PATH", "")
+del _venv_bin
+
 VIRTUALENV_PATCH_FILE = os.path.join(__file__)