fix: allow shared/re-used deps lists across py_test targets#1013
Open
racosta wants to merge 1 commit into
Open
fix: allow shared/re-used deps lists across py_test targets#1013racosta wants to merge 1 commit into
racosta wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


If there is a common list of dependencies which are shared across multiple
py_testtargets andpytest_mainis set toTrueon both of them there is a build issue because thedepslist is mutated and//py/private:default_pytest_mainis included twice/multiple times.Changes are visible to end-users: no
Test plan
Added two tests to demonstrate the behavior. Both must be built together to demonstrate the build issue:
//py/tests/py-test:test_pytest_main_shared_deps_a//py/tests/py-test:test_pytest_main_shared_deps_bbazel test //py/tests/py-test:test_pytest_main_shared_deps_a //py/tests/py-test:test_pytest_main_shared_deps_b