Fix #95 - Neon HTTP 222 error#98
Open
camdroid wants to merge 1 commit into
Open
Conversation
Reference: https://developer.neoncrm.com/accounts/#handling-http-222 Neon accounts can frequently be merged with other accounts for a variety of reasons, and after they're merged, both account ids will still work to reference the account. Fetching the new account id will return an HTTP 200 (OK), but fetching the old account id will return an HTTP 222. We only consider HTTP 200 to be a success, so this causes an error whenever we use the old account id. The only logs that I see this is are when a merge event happens and then tries to update the old account. According to Neon's docs, this should still be fine, and we technically don't ever need to update. This PR downgrades this to a warning instead of an error. I wasn't able to find any instances of an old account id being used after the merge event. If we do see any instances of that in the future, we'll need to investigate to see where the old id is being pulled from, and then update that source. However, this change makes it so that any updates we're trying to make will still be applied to the account, and we can debug the old account id whenever convenient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://developer.neoncrm.com/accounts/#handling-http-222
Neon accounts can frequently be merged with other accounts for a variety of reasons, and after they're merged, both account ids will still work to reference the account. Fetching the new account id will return an HTTP 200 (OK), but fetching the old account id will return an HTTP 222. We only consider HTTP 200 to be a success, so this causes an error whenever we use the old account id.
The only logs that I see this is are when a merge event happens and then tries to update the old account. According to Neon's docs, this should still be fine, and we technically don't ever need to update. This PR downgrades this to a warning instead of an error.
I wasn't able to find any instances of an old account id being used after the merge event. If we do see any instances of that in the future, we'll need to investigate to see where the old id is being pulled from, and then update that source. However, this change makes it so that any updates we're trying to make will still be applied to the account, and we can debug the old account id whenever convenient.