[WIP] Remove redundant compile step from CI workflow#170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run compilestep from the CI workflowOriginal prompt
This section details on the original issue you should resolve
<issue_title>[ci-coach] ci: remove redundant compile step from CI workflow</issue_title>
<issue_description>### Summary
Removes the explicit
npm run compilestep from the CI workflow, which was running TypeScript compilation redundantly before every test run.Optimizations
1. Remove Redundant TypeScript Compilation
Type: Resource / Efficiency
Impact: Estimated ~2–3 seconds savings per runner × 3 runners ≈ 6–9 seconds per CI run
Risk: Low
Changes:
npm run compilestep from thebuildjobRationale: The explicit compile step is never needed because TypeScript is already compiled by downstream scripts:
npm run test:coverage→npm run test:unit(callsnpm run compileinternally) +npm test→ triggerspretest(npm run compile && npm run lint)npm test→ triggerspretest(npm run compile && npm run lint)This means TypeScript was being compiled 3× on Linux and 2× on macOS/Windows per CI run. This PR reduces it to 2× on Linux and 1× on macOS/Windows.
Detailed Analysis
npm scriptscall chain (before this change):test:unitscript → 3.pretesthookpretesthooknpm scriptscall chain (after this change):test:unitscript → 2.pretesthookpretesthookCompilation errors are still surfaced early — they will fail the test step with a clear TypeScript compiler error in the output.
Expected Impact
pretestcontinues to handle compilation and lintingTesting Recommendations
To create a pull request with the changes:
Show patch (38 lines)