Make replayer code portable#3
Conversation
|
Thank you for figuring out all the various changes necessary to make the converter and player Linux compatible! I might want to make some of the changes in a slightly different way, but I will go through them to figure out how they best fit in. I'll probably have some questions along the way... |
|
OK, I finally got around to looking through this PR and trying out the changes, both on Linux (Ubuntu 16.04) and Windows. I have made several changes from your original proposal, which I will describe in the following. To begin with, I have added the commits (which are still attributed to you) on a branch, so you have a chance to look through them before I merge them to master: https://github.com/askeksa/Oidos/tree/portable_player So here are the things I changed:
Do these changes seem reasonable to you? |
|
Yup, that all looks fine, no objections from me. |
|
Great. Thanks again for your contribution. |
sectionsyntax differs a bit for NASM ELF output, now fixed.Basically the same procedure as in gopher-atz/4klang#2 , except I was able to test the exporter now as well.