Conversation
| pub type PhysicalExprRef = Arc<dyn PhysicalExpr>; | ||
|
|
||
| /// Describes execution context for the particular expression. | ||
| pub struct ExprExecutionContext { |
There was a problem hiding this comment.
This context is used to provide additional values for expression execute(...) method. We could make it extendable to allow users to put their own values into it.
| /// require an additional work so this method could return `self`. However, there are | ||
| /// expressions that should be transformed prior to execution, e.g. placeholder that | ||
| /// should be resolved into scalar. | ||
| fn execute( |
There was a problem hiding this comment.
This way we support custom expression that should run sum logic before execution (not only dynamic filters or placeholders, but an arbitrary one).
| Self::raw_execute(&self.metrics, projector, partition, input, &context) | ||
| } | ||
|
|
||
| fn execute_with( |
There was a problem hiding this comment.
execute(...) continues to work as is (take metrics and expressions from self), while execute_with(...) takes them from passed context.
63e5e6c to
c8be448
Compare
c8be448 to
db20cad
Compare
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
No description provided.