Reattach videooutput on too many failures#79
Open
davibe wants to merge 1 commit intoashqal:masterfrom
Open
Conversation
I verified that sometimes AVPlayerItemVideoOutput may become stuck due to broken media, strange network behaviours, or when media ends and the user skips back to a valid position. This can result in - no video rendering - crashes (xcode sees the device as disconnected, no stack trace) When this happens the video output needs to be recreated and reattached ref. https://stackoverflow.com/questions/24800742/iosavplayeritemvideooutput-hasnewpixelbufferforitemtime-doesnt-work-correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I verified that sometimes AVPlayerItemVideoOutput may become stuck due to
broken media, strange network behaviours, or when media ends and the
user skips back to a valid position. This can result in
When this happens the video output needs to be recreated and reattached
ref. https://stackoverflow.com/questions/24800742/iosavplayeritemvideooutput-hasnewpixelbufferforitemtime-doesnt-work-correctly
This relates to #78 as it fixes some of the crashes i experienced. Not sure it fixes all of them, I am still testing