fix/egypt cities#107
Merged
Merged
Conversation
…egardless of how they spelled their city
Closed
Owner
|
Please follow the instructions after reverting ec01972 on your fork, so that I know that running the present works. |
This reverts commit ec01972.
Contributor
Author
|
@ashkulz Per the contribution instructions, I ran the daily update workflow on my fork with the See commit Workflow run: https://github.com/CodeNKoffee/committers.top/actions/runs/20961167433 |
Owner
|
@CodeNKoffee can you revert d78d77e so that I can merge this change? |
This reverts commit d78d77e.
Contributor
Author
|
Reverted. Ready for merge. @ashkulz |
Owner
|
Thanks for the contribution, @CodeNKoffee! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR significantly improves the coverage for Egyptian developers by expanding the
egyptpreset in presets.go.Issue Number:
#108
Changes
tanda→tantaasyut/asiutfayoum/faiyumsharkia/sharqiaal+mansurah/mansouramasr,om+el+donia,heliopolis,nasr+cityWhy This Matters
GitHub's location field is free-text, so developers spell their cities differently. By adding variations, we maximize the chance of correctly identifying Egyptian developers regardless of how they spelled their location.
Testing
+for spaces follows existing patterns in the codebase