Skip to content

fix/egypt cities#107

Merged
ashkulz merged 6 commits into
ashkulz:masterfrom
CodeNKoffee:fix/egypt-cities
Jan 14, 2026
Merged

fix/egypt cities#107
ashkulz merged 6 commits into
ashkulz:masterfrom
CodeNKoffee:fix/egypt-cities

Conversation

@CodeNKoffee

@CodeNKoffee CodeNKoffee commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR significantly improves the coverage for Egyptian developers by expanding the egypt preset in presets.go.

Issue Number:

#108

Changes

  1. Corrected Typos: Fixed tandatanta
  2. Comprehensive Coverage: Added all 27 Egyptian Governorates and their capitals
  3. Major Cities & Hubs: Included industrial/residential areas like:
    • "6th of October", "10th of Ramadan", "New Cairo", "Obour City"
    • "El Gouna", "Ain Shams", "Ain El Sokhna"
  4. Spelling Variations: Added common English transliterations for better matching:
    • asyut / asiut
    • fayoum / faiyum
    • sharkia / sharqia
    • al+mansurah / mansoura
  5. Colloquial Terms: Added masr, om+el+donia, heliopolis, nasr+city

Why This Matters

GitHub's location field is free-text, so developers spell their cities differently. By adding variations, we maximize the chance of correctly identifying Egyptian developers regardless of how they spelled their location.

Testing

  • Verified Go syntax is valid
  • Confirmed URL encoding with + for spaces follows existing patterns in the codebase

@CodeNKoffee CodeNKoffee mentioned this pull request Jan 12, 2026
@ashkulz

ashkulz commented Jan 13, 2026

Copy link
Copy Markdown
Owner

Please follow the instructions after reverting ec01972 on your fork, so that I know that running the present works.

@CodeNKoffee

CodeNKoffee commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

@ashkulz Per the contribution instructions, I ran the daily update workflow on my fork with the fix/egypt-cities branch.

See commit 3348cc1 on my fork's gh-pages branch showing the Egypt preset changes working correctly with the latest city data.

Workflow run: https://github.com/CodeNKoffee/committers.top/actions/runs/20961167433

@ashkulz

ashkulz commented Jan 14, 2026

Copy link
Copy Markdown
Owner

@CodeNKoffee can you revert d78d77e so that I can merge this change?

@CodeNKoffee

CodeNKoffee commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

Reverted. Ready for merge. @ashkulz

@ashkulz ashkulz merged commit 19f2995 into ashkulz:master Jan 14, 2026
1 check passed
@ashkulz

ashkulz commented Jan 14, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution, @CodeNKoffee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants