Fix and optimization for non-x86 architectures#28
Open
buu700 wants to merge 1 commit intoashi009:masterfrom
Open
Fix and optimization for non-x86 architectures#28buu700 wants to merge 1 commit intoashi009:masterfrom
buu700 wants to merge 1 commit intoashi009:masterfrom
Conversation
|
Note, the |
|
So I think the |
Author
|
I didn't see a need for it either, personally. |
|
Hey @ashi009 👋, is there a chance we can get this merged? This is a blocker in my organization |
luboklucka
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #21. I wasn't sure based on that thread whether you'd prefer to remove
sse4_crc32entirely, or if we're keeping it then whether it should be above or below@node-rs/crc32, but I'm happy to make any changes you'd like before merging.