using pdftoppm from poppler instead of ImageMagick#10
Open
luinaudt wants to merge 4 commits intoashafaei:masterfrom
Open
using pdftoppm from poppler instead of ImageMagick#10luinaudt wants to merge 4 commits intoashafaei:masterfrom
luinaudt wants to merge 4 commits intoashafaei:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had a problem with the security from ImageMagicks. I had to use pdftoppm instead.
I don't know if you are interested by this other solution.
On the modification part, I had to change the way slide number are generated since pdftoppm generate the number with more than one digit.
As a result I added one argument to
add_slide. The first one is the number with the right amount of digits. the second argument is for the Id.Thank you for your work.