poc: extend exists/2 to traverse embedded array attributes#231
Draft
nallwhy wants to merge 4 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Extends AshSql.Expr’s lowering of exists/2 so it can traverse {:array, EmbeddedResource} attributes by translating embedded-array traversal into Postgres jsonb_array_elements(...)-based EXISTS fragments, including support for paths that start with relationships and then enter embedded arrays.
Changes:
- Refactors relationship-based
exists/2compilation intodo_relationship_exists_dynamic/9. - Adds embedded-array
exists/2lowering viaembedded_array_exists_dynamic/8, fragment construction helpers, and embedded-path splitting (split_at_first_embedded_array/2). - Introduces compilation support for embedded-array element field markers (
Ash.Query.EmbeddedArrayElementField) to referenceopt.elemfields inside the generatedEXISTSsubquery.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3253
to
+3260
| source_ref = %Ref{ | ||
| attribute: Ash.Resource.Info.attribute(source_resource, first_segment), | ||
| relationship_path: full_at_path, | ||
| resource: bindings.resource | ||
| } | ||
|
|
||
| {source_dyn, acc} = | ||
| do_dynamic_expr(query, source_ref, Map.put(bindings, :no_cast?, true), embedded?, acc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poc of ash-project/ash#2698