bugfix: Re-add bulk_create_index metadata when running bulk creates
#662
Conversation
This is necessary when running bulk create actions with the `sorted?: true` option, and also retains consistency with other built-in data layers Related to ash-project/ash#2452
|
Ash core should be adding the index from the ref that is set. So moving forward, data layers should only be required to add the ref. If that isn't happening somewhere then I believe its a bug in |
|
Have you tested the issue that you're having against the latest |
|
I have, and it works, but I wasn't entirely confident with your 'I haven't reproduced it but I tried something maybe it will work?' fix there, and the commit that removed If the official idea is that data layers don't set |
Currently there is backwards compatibility logic in It was included in that commit accidentally yes, but the change itself I meant to make. As for 'I haven't reproduced it but I tried something maybe it will work?', I'm on very limited time and that was the best I had to offer, it was either that or nothing at all. A PR with a test reproducing the original issue is welcome, and would also then help verify the fix 😄 |
This is necessary when running bulk create actions with the
sorted?: trueoption, and also retains consistency with other built-in data layersRelated to ash-project/ash#2452 and 4b6463b
Contributor checklist
Leave anything that you believe does not apply unchecked.