Skip to content

fix badly handled error on redirect case #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nerzhul wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix badly handled error on redirect case #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fa216e
fix badly handled error on redirect case
nerzhul Dec 29, 2020
98400fe
Merge pull request #1 from nerzhul/patch-1
nerzhul Dec 29, 2020
8eb3634
Merge pull request #2 from nerzhul/master
nerzhul Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions mechanism.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,13 @@ func (m *Mechanism) Evaluate(ip string, count int) (Result, error) {

// There is no clear definition of what to do with errors on a
// redirected domain. Trying to make wise choices here.
if err != nil {
switch err {
case ErrFailedLookup:
return TempError, nil
default:
return PermError, nil
case ErrFailedLookup:
return TempError, nil
default:
return PermError, nil
}
}

return spf.Test(ip), nil
Expand Down