Use #send_notice as a way to 'ack' in Pagerduty service.#3
Open
Use #send_notice as a way to 'ack' in Pagerduty service.#3
Conversation
Owner
Author
|
Hmm, so this might be breaking... going to check with some people I know using this. |
Contributor
|
Curious - why do you want comsat to be able to ack a page? |
Owner
Author
|
That's a valid question. Two things I can think of:
I'm not sure... at first it seemed incredibly useful, but I think you're question is a good one. I do know that I think moving to aliasing notice to alert rather than the other way is a better interface. Need to think on it a bit... |
Contributor
Oh, interesting. So:
|
Repository owner
deleted a comment from
erenakkaya
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how this hasn't been in here before, seems required.