fix(event_bus): panic if multiple goroutine call publish and then wait#49
Open
ken00535 wants to merge 1 commit intoasaskevich:masterfrom
Open
fix(event_bus): panic if multiple goroutine call publish and then wait#49ken00535 wants to merge 1 commit intoasaskevich:masterfrom
ken00535 wants to merge 1 commit intoasaskevich:masterfrom
Conversation
because of wg's counter can't be a negative number, if call Wait() and then call Add(1) before Wait() complete, it will throw panic "WaitGroup is reused before previous Wait has returned". so add a mutex to prevent this issue. for more detail, see: https://stackoverflow.com/questions/48351816/waitgroup-is-reused-before-previous-wait-unknown-reason
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 83.26% 81.86% -1.41%
==========================================
Files 4 4
Lines 251 215 -36
==========================================
- Hits 209 176 -33
+ Misses 29 26 -3
Partials 13 13
Continue to review full report at Codecov.
|
|
There is a bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of wg's counter can't be a negative number, if call Wait() and then call Add(1) before Wait() complete, it will throw a panic "WaitGroup is reused before previous Wait has returned". so this PR add a mutex to fix the issue.
For more detail, see:
https://stackoverflow.com/questions/48351816/waitgroup-is-reused-before-previous-wait-unknown-reason
I write a test TestSubscribeAsyncWithMultipleGoroutine that can reproduce the issue.