Open
Conversation
Author
|
Looks like this project supports go versions well before 1.7 when the context package was added to the standard lib. Feel free to close the PR if this is a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds and implements an interface method
SubscribeAsyncWithNewContextwith same signature asSubscribeAsyncbut is "Context-aware" by creating a newcontext.Background()to pass to the handler function.My company has this use case because our server handles incoming requests partly by
Publish-ing an event to a topic with at least one async subscriber which makes other outbound network requests. The server cancels the context once it sends a response. Routinely, the cancelled context from the upstream request prevents the subscriber handler function from completing.This feature allows subscribers to opt into being called with a background Context so that cancelled contexts do not adversely affect them.