Open
Conversation
Parsing of %directory% is advertised in the run menu, but the code wasn't there. Retrieve current dir using QFileInfo since QUrl does not provide clean dir_path without "file://" scheme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parsing of
%directory%placeholders is advertised in the run menu, but the code wasn't actually there.The current directory is retrieved using
QFileInfosinceQUrldoes not provide clean directory path without "file://" scheme. Also to avoid the use of hard-coded regex.%path% parsing is there but it's not advertised, but seems okay to leave it as is.