Introduce Mode enum#122
Merged
robberwick merged 3 commits intoarvydas:release/2.0-devfrom Feb 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
blinkstickpackage to improve the handling of device modes by introducing a newModeenum and updating the relevant methods and tests. The most important changes include adding theModeenum, updating theset_modemethod to accept the new enum, and adding tests to validate the new functionality.Enhancements to device mode handling:
src/blinkstick/enums.py: Introduced theModeenum to represent different device modes. [1] [2]src/blinkstick/clients/blinkstick.py: Updated theset_modemethod to accept either an integer or aModeenum, and added logic to convert the enum to its corresponding integer value. [1] [2] [3]Testing improvements:
tests/clients/test_blinkstick.py: Added a parameterized test to ensure that theset_modemethod raises an exception when an invalid mode is passed, and accepts valid modes including the newModeenum values. [1] [2]