Skip to content

fix: ensure backend check correctly raises exception when not set#118

Merged
robberwick merged 1 commit intoarvydas:release/2.0-devfrom
robberwick:better-no-backend-detection
Feb 16, 2025
Merged

fix: ensure backend check correctly raises exception when not set#118
robberwick merged 1 commit intoarvydas:release/2.0-devfrom
robberwick:better-no-backend-detection

Conversation

@robberwick
Copy link
Collaborator

This pull request includes changes to the BlinkStick client in src/blinkstick/clients/blinkstick.py and its corresponding tests in tests/clients/test_blinkstick.py. The most important changes include updating the backend check in the __getattribute__ method and modifying the test for methods requiring a backend.

Backend check update:

Test modifications:

  • tests/clients/test_blinkstick.py: Modified the test_all_methods_require_backend test to directly instantiate BlinkStick without using a mock or passing a device, ensuring that all methods raise an exception when the backend is not set.

@robberwick robberwick requested a review from Copilot February 16, 2025 08:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@robberwick robberwick merged commit 381c18a into arvydas:release/2.0-dev Feb 16, 2025
17 checks passed
@robberwick robberwick deleted the better-no-backend-detection branch February 16, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants