Use multi-Node.js-version HID.node, and process.nextTick for callbacks#17
Open
SkyLined wants to merge 3 commits intoarvydas:masterfrom
SkyLined:master
Open
Use multi-Node.js-version HID.node, and process.nextTick for callbacks#17SkyLined wants to merge 3 commits intoarvydas:masterfrom SkyLined:master
SkyLined wants to merge 3 commits intoarvydas:masterfrom
SkyLined:master
Conversation
added 3 commits
March 23, 2015 10:33
* use process.nextTick to call callbacks, which prevents Node./js crashing on recursive callbacks (these would cause stack exhaustion in the original code. * On Windows, add pre-compiled HID.node files for multiple versions of Node.js. It should now work with Node.js version v0.8.0 and higher, except for v0.11.0-v0.11.15. * Adjust code to attempt to load each pre-compiled HID.node file until one works, or report an error if none of them do.
* Add "-multi-hid" to identify this particular build
* Variable "isWin" is used later on in the file, so cannot be removed as it was in a previous commit.
|
Whilst trying to move some code from fedora to windows I came across the windows 8 issue, I can confirm this PR works on windows 8.1 with node 0.12.2 (64bit) 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my current version of the master branch of BlinkStick, with the changes I proposed in the forum:
Tested with multiple Node.js versions on windows 8.1