Integration of Timed Metadata for HLS#1584
Open
git-audo wants to merge 8 commits intoarut:masterfrom
Open
Conversation
added 8 commits
October 20, 2020 12:29
|
Is this pullrequest working properly? |
|
Bump, will this ever be added into the main branch? |
|
Never |
Author
|
I would say no, the last PR that was merged to master dates 5 years ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I worked on the support for HLS timed metadata as described in the Apple documentation [0]. Since the metadata is required to be in the ID3 format, I included a third party library [1] for the handling of this structure. If this could be of some interest it'd be great to know. I'd really appreciate a review of the added code, if someone has the time to do it. Thank you and good work!
[0] https://developer.apple.com/library/archive/documentation/AudioVideo/Conceptual/HTTP_Live_Streaming_Metadata_Spec/Introduction/Introduction.html
[1] https://github.com/larsbs/id3v2lib