Self Wake Up Timer#685
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@copilot review but do not make fixes |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (12)
👮 Files not reviewed due to content moderation or server errors (12)
📝 Walkthrough
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 SkillSpector (2.3.7)apps/desktop/resources/agent-skills/ade-cli-control-plane/SKILL.mdSkillSpector returned invalid JSON output Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| initialInput: opener, | ||
| modelId: modelId, | ||
| reasoningEffort: cliReasoningEffort, | ||
| fastMode: fastModeSupported ? codexFastMode : nil, |
There was a problem hiding this comment.
fastModeSupported returns false whenever sessionMode == .cli (lines 367-380), so this new startCliSession argument is always nil for CLI launches. A user’s saved or selected fast/no-fast value is therefore not forwarded to the remote command, while the desktop/CLI path now expects fastMode to drive service_tier for tracked CLI sessions.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/ios/ADE/Views/Work/WorkNewChatScreen.swift
Line: 655
Comment:
**CLI fast mode dropped**
`fastModeSupported` returns `false` whenever `sessionMode == .cli` (lines 367-380), so this new `startCliSession` argument is always `nil` for CLI launches. A user’s saved or selected fast/no-fast value is therefore not forwarded to the remote command, while the desktop/CLI path now expects `fastMode` to drive `service_tier` for tracked CLI sessions.
How can I resolve this? If you propose a fix, please make it concise.
| initialInput: opener, | ||
| modelId: modelId, | ||
| reasoningEffort: cliReasoning, | ||
| fastMode: fastModeSupported ? codexFastMode : nil, |
There was a problem hiding this comment.
fastModeSupported is explicitly gated to chat mode in this view (lines 161-173), so the newly added CLI fastMode parameter is always sent as nil. Hub-started CLI sessions therefore ignore the fast/no-fast setting even though work.startCliSession now consumes it to build the provider launch command.
Artifacts
Repro: focused HubComposerDrawer CLI fastMode payload harness
- Contains supporting evidence from the run (text/x-python; charset=utf-8).
Repro: harness output showing CLI fastMode is nil for selected true and false
- Keeps the command output available without making the summary code-heavy.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/ios/ADE/Views/Hub/HubComposerDrawer.swift
Line: 721
Comment:
**CLI fast mode dropped**
`fastModeSupported` is explicitly gated to chat mode in this view (lines 161-173), so the newly added CLI `fastMode` parameter is always sent as `nil`. Hub-started CLI sessions therefore ignore the fast/no-fast setting even though `work.startCliSession` now consumes it to build the provider launch command.
How can I resolve this? If you propose a fix, please make it concise.
1 participant
Summary
Describe the change.
What Changed
Key files and behaviors.
Validation
How you tested.
Risks
Anything to watch.
Greptile Summary
This PR adds a unified way to start ADE Work chats and tracked CLI sessions. The main changes are:
ade new chat --mode chat|cliwith auto-lane creation and prompt kickoff support.fastModethrough CLI session RPC and sync remote-command launch paths.Confidence Score: 4/5
Mostly safe to merge after fixing iOS CLI fast-mode forwarding.
The CLI and sync server changes are covered, but two iOS launch paths drop the newly added CLI
fastModeargument because they use a chat-only support gate.apps/ios/ADE/Views/Work/WorkNewChatScreen.swift;apps/ios/ADE/Views/Hub/HubComposerDrawer.swiftWhat T-Rex did
Important Files Changed
ade new chatunified chat/CLI command, auto-lane creation, dry-run output, and shared fast-mode parsing.fastModeand legacy alias parsing tostart_cli_sessionand forwards it into tracked CLI launch construction.fastModeon remotework.startCliSessioncalls and forwards it to the CLI launch builder.fastModeand a deprecatedcodexFastModealias.fastModeserialization to iOSstartCliSessionremote command calls.nil.nil.Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant User participant AdeCLI as ade new chat participant RPC as ADE RPC / Sync participant Lane as Lane service participant Chat as Work chat service participant PTY as Tracked CLI launcher User->>AdeCLI: "ade new chat --mode chat|cli --lane auto|id --prompt ..." alt auto-create lane AdeCLI->>RPC: create_lane(name/base/etc.) RPC->>Lane: create lane Lane-->>RPC: lane id RPC-->>AdeCLI: lane result end alt mode chat AdeCLI->>RPC: run_ade_action(chat.createSession, launch args) RPC->>Chat: create session Chat-->>RPC: session id RPC-->>AdeCLI: session result opt prompt supplied AdeCLI->>RPC: run_ade_action(chat.sendMessage) RPC->>Chat: send first message Chat-->>RPC: accepted end else mode cli AdeCLI->>RPC: start_cli_session(lane/provider/model/reasoning/fastMode) RPC->>PTY: buildTrackedCliLaunchCommand(...) PTY-->>RPC: terminal session RPC-->>AdeCLI: pty/session result end%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant User participant AdeCLI as ade new chat participant RPC as ADE RPC / Sync participant Lane as Lane service participant Chat as Work chat service participant PTY as Tracked CLI launcher User->>AdeCLI: "ade new chat --mode chat|cli --lane auto|id --prompt ..." alt auto-create lane AdeCLI->>RPC: create_lane(name/base/etc.) RPC->>Lane: create lane Lane-->>RPC: lane id RPC-->>AdeCLI: lane result end alt mode chat AdeCLI->>RPC: run_ade_action(chat.createSession, launch args) RPC->>Chat: create session Chat-->>RPC: session id RPC-->>AdeCLI: session result opt prompt supplied AdeCLI->>RPC: run_ade_action(chat.sendMessage) RPC->>Chat: send first message Chat-->>RPC: accepted end else mode cli AdeCLI->>RPC: start_cli_session(lane/provider/model/reasoning/fastMode) RPC->>PTY: buildTrackedCliLaunchCommand(...) PTY-->>RPC: terminal session RPC-->>AdeCLI: pty/session result endPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat: add unified ADE chat launch comman..." | Re-trigger Greptile