fix(telegram): stage managed bot until owner capture#1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Fast Path
swift test --package-path apps/macos --no-parallel --filter 'TelegramSetupBootstrapTests|ConsumerSetupResumeTests'passed 32 tests;pnpm exec vitest run src/config/config.allowlist-requires-allowfrom.test.tspassed 15 tests;/tmp/jarvis-backend-telegram-venv/bin/python -m pytest services/jarvis-backend/tests/test_app.pypassed 48 tests;git diff --checkpassed.@jarvis_f866035f_botwas created/messaged under an already-expired setup, and@jarvis_9773392b_botdid not exist.Why This Matters
A user can do the right thing in Telegram and still end up with a silent or developer-looking bot if Jarvis enables polling before it knows who the owner is, or if the backend setup expires/deletes before the app retrieves the child token.
This PR fixes both product failure shapes:
Scope Boundary
Changed:
Did not change:
Verification
Local:
Live investigation evidence from this run:
tgms_bZwEFrpVl2ByKllgOP3HTAforjarvis_9773392b_botreturned pending until expiry, then410 Telegram setup expired.@jarvis_f866035f_bothad outgoing/startandhifrom user id1336356696.@jarvis_9773392b_botdid not exist, so no child token could be issued for the current setup.Security Impact
Human Verification
AI Assistance