Skip to content

fix(cli): prefer stable Jarvis recorder nodes#1090

Draft
artemgetmann wants to merge 1 commit into
mainfrom
codex/screen-record-node-stability-20260704
Draft

fix(cli): prefer stable Jarvis recorder nodes#1090
artemgetmann wants to merge 1 commit into
mainfrom
codex/screen-record-node-stability-20260704

Conversation

@artemgetmann

Copy link
Copy Markdown
Owner

Review Fast Path

  • User path fixed: openclaw screen record --app Telegram can now choose the already-connected/permitted installed Jarvis macOS recorder node instead of failing when screen-record-proof or duplicate debug nodes are also present.
  • Proof: pnpm test -- src/cli/screen-record.test.ts; pnpm exec oxfmt --check src/cli/screen-record.ts src/cli/screen-record.test.ts; pnpm exec oxlint --type-aware src/cli/screen-record.ts src/cli/screen-record.test.ts; pnpm tsgo.
  • Shared-state footgun removed: recorder node selection no longer forces operators into transient exact-node-id guessing when a better Jarvis node is visible.
  • Still hurts: no live openclaw screen record run in this PR; I did not touch /Applications/Jarvis.app, pairing files, or shared/default runtime.

Why This Matters

  • Video proof should use the user's real permitted Jarvis app identity when it is connected and advertises screen.record.
  • The proof fixture is still supported, but it should not beat installed Jarvis when both are healthy.
  • Stale or duplicate candidates now print node ids, names, bundle paths, and Screen Recording state so the next operator can choose --node deliberately.

Scope Boundary

  • Changed only CLI default selection and ambiguity diagnostics for screen recording nodes.
  • Did not auto-approve device repair requests.
  • Did not delete stale paired nodes.
  • Did not restart or mutate any Jarvis/shared runtime.

Verification

  • pnpm test -- src/cli/screen-record.test.ts
  • pnpm exec oxfmt --check src/cli/screen-record.ts src/cli/screen-record.test.ts
  • pnpm exec oxlint --type-aware src/cli/screen-record.ts src/cli/screen-record.test.ts
  • pnpm tsgo

AI Assistance

  • AI-assisted
  • Testing degree: targeted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant