feat(consumer): seed heartbeat check-in defaults#1019
Closed
artemgetmann wants to merge 1 commit into
Closed
Conversation
19c952d to
32153c3
Compare
- What: seed a concrete HEARTBEAT.md for consumer workspaces and preserve custom heartbeat files. - What: configure daily Telegram DM heartbeat delivery after consumer DM pairing when no custom heartbeat route exists. - Why: make proactive check-ins usable by default without sending to groups or clobbering existing user intent. - Risk: heartbeat setup is still an early slice; delayed opt-in prompts, abandoned-session routing, and personal-tool scans remain follow-up work.
32153c3 to
fec59b7
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Fast Path
docs/consumer/heartbeat.mdnow documents heartbeat defaults, opt-out behavior, personal-tool boundaries, and follow-up context rules.swift test --package-path apps/macos --filter AgentWorkspaceTests;swift test --package-path apps/macos --filter ConsumerBootstrapTests;git diff --check.directPolicy: allow, updates stale setup-owned Telegram recipients/account ids/direct-policy blocks on re-pair, preserves explicit Telegram group/topic/secondary routes, preserves custom non-Telegram heartbeat routes, preserves blank/comment-only HEARTBEAT.md opt-outs, and avoids writing heartbeat files into unsafe arbitrary workspaces.Why This Matters
Scope Boundary
Changed:
directPolicy: allowfor generated paired-DM heartbeat delivery so doctor does not warn on our own generated config and delivery is notdm-blocked.target: noneheartbeat to Telegram delivery.target: telegramheartbeat.Not changed:
Product Follow-Up Plan
Setup prompt copy under review:
If accepted, optional personal-message opt-in:
Abandoned task behavior to implement later:
drop: dismiss this exact surfaced item unless it changes materially.snooze: suppress until the requested follow-up time.continue: route the user's missing input back to the original work context, not continue the task inside heartbeat DM.Verification
swift test --package-path apps/macos --filter AgentWorkspaceTestsswift test --package-path apps/macos --filter ConsumerBootstrapTestsgit diff --checkcodex review --base origin/mainfirst found a P2 about overwriting blank/comment-only HEARTBEAT.md opt-outs; fixed by seeding only missing files and adding a regression test.codex review --base origin/mainthen found P2s for unsafe workspace writes and stale recipient preservation; fixed by moving heartbeat seeding behind the safety decision and replacing stale recipients when enabling Telegram fromtarget: none.codex review --base origin/mainthen found a P2 about missing generateddirectPolicy; fixed by pinningdirectPolicy: allowfor paired-DM heartbeat delivery.codex review --base origin/mainthen found a P1 about stale explicit Telegram heartbeat recipients on re-pair; fixed by updating setup-ownedtovalues.codex review --base origin/mainthen found a P2 about stale explicit heartbeat account ids on re-pair; fixed by updating setup-ownedaccountIdto the consumer default.codex review --base origin/mainthen found a P2 about preserving blocked direct policy while enabling DM delivery; fixed by forcing setup-owneddirectPolicy: allow.codex review --base origin/mainthen found a P2 about clobbering explicit Telegram routes; fixed by tracking the previous paired DM and only replacing known setup-owned routes.codex review --base origin/mainthen found a P2 about preserving stale setup-owned Telegram heartbeat routing during the pre-DM setup window; fixed by disabling setup-owned heartbeat delivery until the fresh owner DM is captured.AI Assistance