Improve nested set build performance#2273
Merged
anvit merged 4 commits intoartefactual:qa/2.xfrom Feb 18, 2026
Merged
Conversation
This improves performance by reducing the number of SQL statements that need to be executed.
[] is a direct language construct of PHP and does not add the overhead of calling a function like array_push.
Since the ids come from the database, and the lft and rgt values are constructed in this class, there is no need for using placeholders for SQL injection. Using the IDs directly in this manner makes the code easier to read *and* it's much faster.
sarah-mason
added
the
Community
anvit
reviewed
Feb 18, 2026
| $ids[] = $node['id']; | ||
| } | ||
|
|
||
| $sql = sprintf( |
Contributor
There was a problem hiding this comment.
Neat! Batching these up as a single big query should be a big improvement
Contributor
Author
There was a problem hiding this comment.
For sure, it was a huge performance improvement from my testing!
anvit
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2272
Reduce the execution time of
propel:build-nested-setby around 90% by applying a couple of performance optimizations:[]to create child-parent array instead ofarray_push()