Changes after testing port translation map for https access to MC-2#283
Changes after testing port translation map for https access to MC-2#283rrivera747 merged 19 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements and tests port translation mapping functionality for HTTPS access to MC-2, along with improvements to error handling, debugging capabilities, and code robustness.
Key changes include:
- Implementation of port translation mapping for remote gateway icons and URL translation with GET parameter encoding support
- Enhanced error messages with exception details in database and configuration interfaces
- Addition of a force backbone save parameter to the import groups tool
- Improved log display in shell scripts using awk to show context around errors
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/otsdaq_import_groups_from_export_path.cc | Added forceBackboneSave parameter, improved error messages with exception details, added try-catch in main, extensive debug output additions, and setActiveView calls to restore original versions |
| tools/ots | Replaced simple tail commands with sophisticated awk scripts to show error context in logs, added port translation map file reading and display functionality |
| otsdaq/TablePlugins/ARTDAQTableBase/ARTDAQTableBase.cc | Modified SERVICE_DATA_PATH handling to fallback to USER_DATA/ServiceData when not set |
| otsdaq/GatewaySupervisor/GatewaySupervisor.h | Added declaration for translateRemoteIconStringForRequestOrigin function |
| otsdaq/GatewaySupervisor/GatewaySupervisor.cc | Added TLVL debug constants, implemented port translation map parsing, translateRemoteIconStringForRequestOrigin function, GET parameter encoding/translation, and improved error messages |
| otsdaq/ConfigurationInterface/Database_configInterface.cc | Enhanced exception handling with try-catch blocks, improved error messages, added validation for empty table group member maps |
| otsdaq/ConfigurationInterface/ConfigurationManagerRW.cc | Added validation to prevent saving table groups with empty member maps |
| otsdaq/ConfigurationInterface/ConfigurationManager.cc | Improved error messages, added specific messaging for XDAQ Context Table, fixed file format with trailing newline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@rrivera747 I've opened a new pull request, #284, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@rrivera747 I've opened a new pull request, #285, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@rrivera747 I've opened a new pull request, #286, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Add logging for ignored lines in port translation file.
Remove redundant validation in port translation file parser
No description provided.