Skip to content

Changes after testing port translation map for https access to MC-2#283

Merged
rrivera747 merged 19 commits intodevelopfrom
rrivera/testingPortTranslationMap
Jan 9, 2026
Merged

Changes after testing port translation map for https access to MC-2#283
rrivera747 merged 19 commits intodevelopfrom
rrivera/testingPortTranslationMap

Conversation

@rrivera747
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements and tests port translation mapping functionality for HTTPS access to MC-2, along with improvements to error handling, debugging capabilities, and code robustness.

Key changes include:

  • Implementation of port translation mapping for remote gateway icons and URL translation with GET parameter encoding support
  • Enhanced error messages with exception details in database and configuration interfaces
  • Addition of a force backbone save parameter to the import groups tool
  • Improved log display in shell scripts using awk to show context around errors

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
tools/otsdaq_import_groups_from_export_path.cc Added forceBackboneSave parameter, improved error messages with exception details, added try-catch in main, extensive debug output additions, and setActiveView calls to restore original versions
tools/ots Replaced simple tail commands with sophisticated awk scripts to show error context in logs, added port translation map file reading and display functionality
otsdaq/TablePlugins/ARTDAQTableBase/ARTDAQTableBase.cc Modified SERVICE_DATA_PATH handling to fallback to USER_DATA/ServiceData when not set
otsdaq/GatewaySupervisor/GatewaySupervisor.h Added declaration for translateRemoteIconStringForRequestOrigin function
otsdaq/GatewaySupervisor/GatewaySupervisor.cc Added TLVL debug constants, implemented port translation map parsing, translateRemoteIconStringForRequestOrigin function, GET parameter encoding/translation, and improved error messages
otsdaq/ConfigurationInterface/Database_configInterface.cc Enhanced exception handling with try-catch blocks, improved error messages, added validation for empty table group member maps
otsdaq/ConfigurationInterface/ConfigurationManagerRW.cc Added validation to prevent saving table groups with empty member maps
otsdaq/ConfigurationInterface/ConfigurationManager.cc Improved error messages, added specific messaging for XDAQ Context Table, fixed file format with trailing newline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/ots Outdated
Comment thread tools/ots Outdated
Comment thread tools/ots Outdated
Comment thread tools/ots Outdated
Comment thread otsdaq/TablePlugins/ARTDAQTableBase/ARTDAQTableBase.cc Outdated
Comment thread tools/otsdaq_import_groups_from_export_path.cc Outdated
Comment thread otsdaq/GatewaySupervisor/GatewaySupervisor.cc Outdated
Comment thread otsdaq/GatewaySupervisor/GatewaySupervisor.cc Outdated
Comment thread otsdaq/GatewaySupervisor/GatewaySupervisor.cc Outdated
Comment thread otsdaq/GatewaySupervisor/GatewaySupervisor.cc Outdated
rrivera747 and others added 6 commits January 8, 2026 12:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 8, 2026

@rrivera747 I've opened a new pull request, #284, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 8, 2026

@rrivera747 I've opened a new pull request, #285, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 8, 2026

@rrivera747 I've opened a new pull request, #286, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 3 commits January 8, 2026 20:41
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Add logging for ignored lines in port translation file.
eflumerf
eflumerf previously approved these changes Jan 8, 2026
Remove redundant validation in port translation file parser
@rrivera747 rrivera747 merged commit 6ce6d6e into develop Jan 9, 2026
6 checks passed
@rrivera747 rrivera747 deleted the rrivera/testingPortTranslationMap branch January 9, 2026 02:34
@github-project-automation github-project-automation Bot moved this from 📋 Triage to 🎉 Done in art-daq Work Tracker Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

5 participants