Merged
Conversation
Webpack tried to warn us for our large assets, which isn't relevant for a browser extension so much.
Owner
|
@RoelN it looks like this removes the build error from webpack that warns about a large bundle size – but that bundle size is unavoidable due to Recursive being part of the bundle, so the warning is unnecessary noise. Correct? |
Collaborator
Author
|
@arrowtype Yes, that was my thinking. For a website this warning would be fair, but it's not really relevant for a browser extension, is my thinking. |
Collaborator
Author
|
ps. I tried to describe the changes in the individual commits (and their messages), should've pointed that out! |
Owner
|
Ah, I see that now! I never think to look at the description portion of a commit, but maybe I should. Totally agreed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.