-
Notifications
You must be signed in to change notification settings - Fork 3
feat(kubernetes): add agent execution mode, executor-agent, sidecar refactor, GKE Sandbox, image & deps upgrades #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cfc5c69
feat: add GKE Sandbox (gVisor) support for execution pods
gafda 836645b
feat(kubernetes): add agent execution mode and image pull secrets
gafda fd2e3a6
feat(docs): update sidecar image and executor port
gafda 317db84
feat(docker): upgrade base image to trixie-dev
gafda 5a5fe2d
feat(docker): upgrade base images and dependencies
gafda 9f6f43d
feat(kubernetes): add image pull policy and secrets support
gafda 0104bd6
feat: add Redis Cluster, Sentinel, and TLS/SSL support
gafda c7c4bcb
feat(kubernetes): add GKE Sandbox compatibility checks
gafda 0f1a573
fix: pass TLS kwargs in config validator and disable ssl_check_hostna…
gafda 851dad1
fix: use mode-aware Redis client in config validator and remove local…
gafda 8afdee4
fix: address Copilot review issues from PR #33
gafda 35de004
feat(redis): fix cluster connection failures and add TLS integration …
gafda c527804
fix: Redis Cluster cross-slot transaction errors and version display
gafda d0ae73f
fix: address open Copilot review comments from PR #33
gafda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,7 +145,7 @@ jobs: | |
| uses: ./.github/workflows/docker-build-reusable.yml | ||
| secrets: inherit | ||
| with: | ||
| image_name: kubecoderun-sidecar | ||
| image_name: kubecoderun-sidecar-agent | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It appears you are no longer building |
||
| dockerfile: docker/sidecar/Dockerfile | ||
| context: docker/sidecar | ||
| image_tag: ${{ needs.changes.outputs.image_tag }} | ||
|
|
@@ -344,7 +344,7 @@ jobs: | |
| uses: ./.github/workflows/docker-retag-reusable.yml | ||
| secrets: inherit | ||
| with: | ||
| image_name: kubecoderun-sidecar | ||
| image_name: kubecoderun-sidecar-agent | ||
| new_tag: ${{ needs.changes.outputs.image_tag }} | ||
| previous_tag: ${{ needs.changes.outputs.previous_tag }} | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -200,3 +200,5 @@ config/local.py | |
|
|
||
| # Hatch auto-generated version file | ||
| _version.py | ||
|
|
||
| .pdm-python | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,231 @@ | ||
| # Redis Cluster with TLS for integration testing | ||
| # | ||
| # This mimics a production GCP Memorystore Redis Cluster setup: | ||
| # - 6-node cluster (3 masters + 3 replicas) with TLS enabled | ||
| # - No authentication (no password) | ||
| # - Server-side TLS with CA verification (no mutual TLS / no client certs) | ||
| # - Accessible on localhost ports 6380-6385 (TLS) | ||
| # | ||
| # Usage: | ||
| # docker compose -f docker-compose.redis-cluster-tls.yml up -d | ||
| # | ||
| # Test with: | ||
| # redis-cli -c -p 6380 --tls --cacert tests/tls-certs/ca.crt CLUSTER INFO | ||
|
|
||
| services: | ||
| redis-tls-node-0: | ||
| image: redis:7-alpine | ||
| container_name: redis-tls-cluster-0 | ||
| ports: | ||
| - "127.0.0.1:6380:6380" | ||
| - "127.0.0.1:16380:16380" | ||
| volumes: | ||
| - redis-tls-cluster-0:/data | ||
| - ./tests/tls-certs:/tls:ro | ||
| command: > | ||
| redis-server | ||
| --port 0 | ||
| --tls-port 6380 | ||
| --tls-cert-file /tls/redis.crt | ||
| --tls-key-file /tls/redis.key | ||
| --tls-ca-cert-file /tls/ca.crt | ||
| --tls-auth-clients no | ||
| --tls-replication yes | ||
| --cluster-enabled yes | ||
| --cluster-config-file nodes.conf | ||
| --cluster-node-timeout 5000 | ||
| --appendonly yes | ||
| --bind 0.0.0.0 | ||
| --protected-mode no | ||
| healthcheck: | ||
| test: ["CMD", "redis-cli", "-p", "6380", "--tls", "--cert", "/tls/redis.crt", "--key", "/tls/redis.key", "--cacert", "/tls/ca.crt", "ping"] | ||
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 | ||
|
|
||
| redis-tls-node-1: | ||
| image: redis:7-alpine | ||
| container_name: redis-tls-cluster-1 | ||
| ports: | ||
| - "127.0.0.1:6381:6381" | ||
| - "127.0.0.1:16381:16381" | ||
| volumes: | ||
| - redis-tls-cluster-1:/data | ||
| - ./tests/tls-certs:/tls:ro | ||
| command: > | ||
| redis-server | ||
| --port 0 | ||
| --tls-port 6381 | ||
| --tls-cert-file /tls/redis.crt | ||
| --tls-key-file /tls/redis.key | ||
| --tls-ca-cert-file /tls/ca.crt | ||
| --tls-auth-clients no | ||
| --tls-replication yes | ||
| --cluster-enabled yes | ||
| --cluster-config-file nodes.conf | ||
| --cluster-node-timeout 5000 | ||
| --appendonly yes | ||
| --bind 0.0.0.0 | ||
| --protected-mode no | ||
| healthcheck: | ||
| test: ["CMD", "redis-cli", "-p", "6381", "--tls", "--cert", "/tls/redis.crt", "--key", "/tls/redis.key", "--cacert", "/tls/ca.crt", "ping"] | ||
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 | ||
|
|
||
| redis-tls-node-2: | ||
| image: redis:7-alpine | ||
| container_name: redis-tls-cluster-2 | ||
| ports: | ||
| - "127.0.0.1:6382:6382" | ||
| - "127.0.0.1:16382:16382" | ||
| volumes: | ||
| - redis-tls-cluster-2:/data | ||
| - ./tests/tls-certs:/tls:ro | ||
| command: > | ||
| redis-server | ||
| --port 0 | ||
| --tls-port 6382 | ||
| --tls-cert-file /tls/redis.crt | ||
| --tls-key-file /tls/redis.key | ||
| --tls-ca-cert-file /tls/ca.crt | ||
| --tls-auth-clients no | ||
| --tls-replication yes | ||
| --cluster-enabled yes | ||
| --cluster-config-file nodes.conf | ||
| --cluster-node-timeout 5000 | ||
| --appendonly yes | ||
| --bind 0.0.0.0 | ||
| --protected-mode no | ||
| healthcheck: | ||
| test: ["CMD", "redis-cli", "-p", "6382", "--tls", "--cert", "/tls/redis.crt", "--key", "/tls/redis.key", "--cacert", "/tls/ca.crt", "ping"] | ||
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 | ||
|
|
||
| redis-tls-node-3: | ||
| image: redis:7-alpine | ||
| container_name: redis-tls-cluster-3 | ||
| ports: | ||
| - "127.0.0.1:6383:6383" | ||
| - "127.0.0.1:16383:16383" | ||
| volumes: | ||
| - redis-tls-cluster-3:/data | ||
| - ./tests/tls-certs:/tls:ro | ||
| command: > | ||
| redis-server | ||
| --port 0 | ||
| --tls-port 6383 | ||
| --tls-cert-file /tls/redis.crt | ||
| --tls-key-file /tls/redis.key | ||
| --tls-ca-cert-file /tls/ca.crt | ||
| --tls-auth-clients no | ||
| --tls-replication yes | ||
| --cluster-enabled yes | ||
| --cluster-config-file nodes.conf | ||
| --cluster-node-timeout 5000 | ||
| --appendonly yes | ||
| --bind 0.0.0.0 | ||
| --protected-mode no | ||
| healthcheck: | ||
| test: ["CMD", "redis-cli", "-p", "6383", "--tls", "--cert", "/tls/redis.crt", "--key", "/tls/redis.key", "--cacert", "/tls/ca.crt", "ping"] | ||
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 | ||
|
|
||
| redis-tls-node-4: | ||
| image: redis:7-alpine | ||
| container_name: redis-tls-cluster-4 | ||
| ports: | ||
| - "127.0.0.1:6384:6384" | ||
| - "127.0.0.1:16384:16384" | ||
| volumes: | ||
| - redis-tls-cluster-4:/data | ||
| - ./tests/tls-certs:/tls:ro | ||
| command: > | ||
| redis-server | ||
| --port 0 | ||
| --tls-port 6384 | ||
| --tls-cert-file /tls/redis.crt | ||
| --tls-key-file /tls/redis.key | ||
| --tls-ca-cert-file /tls/ca.crt | ||
| --tls-auth-clients no | ||
| --tls-replication yes | ||
| --cluster-enabled yes | ||
| --cluster-config-file nodes.conf | ||
| --cluster-node-timeout 5000 | ||
| --appendonly yes | ||
| --bind 0.0.0.0 | ||
| --protected-mode no | ||
| healthcheck: | ||
| test: ["CMD", "redis-cli", "-p", "6384", "--tls", "--cert", "/tls/redis.crt", "--key", "/tls/redis.key", "--cacert", "/tls/ca.crt", "ping"] | ||
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 | ||
|
|
||
| redis-tls-node-5: | ||
| image: redis:7-alpine | ||
| container_name: redis-tls-cluster-5 | ||
| ports: | ||
| - "127.0.0.1:6385:6385" | ||
| - "127.0.0.1:16385:16385" | ||
| volumes: | ||
| - redis-tls-cluster-5:/data | ||
| - ./tests/tls-certs:/tls:ro | ||
| command: > | ||
| redis-server | ||
| --port 0 | ||
| --tls-port 6385 | ||
| --tls-cert-file /tls/redis.crt | ||
| --tls-key-file /tls/redis.key | ||
| --tls-ca-cert-file /tls/ca.crt | ||
| --tls-auth-clients no | ||
| --tls-replication yes | ||
| --cluster-enabled yes | ||
| --cluster-config-file nodes.conf | ||
| --cluster-node-timeout 5000 | ||
| --appendonly yes | ||
| --bind 0.0.0.0 | ||
| --protected-mode no | ||
| healthcheck: | ||
| test: ["CMD", "redis-cli", "-p", "6385", "--tls", "--cert", "/tls/redis.crt", "--key", "/tls/redis.key", "--cacert", "/tls/ca.crt", "ping"] | ||
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 | ||
|
|
||
| # Initializer: creates TLS cluster from the 6 nodes | ||
| redis-tls-cluster-init: | ||
| image: redis:7-alpine | ||
| container_name: redis-tls-cluster-init | ||
| volumes: | ||
| - ./tests/tls-certs:/tls:ro | ||
| depends_on: | ||
| redis-tls-node-0: | ||
| condition: service_healthy | ||
| redis-tls-node-1: | ||
| condition: service_healthy | ||
| redis-tls-node-2: | ||
| condition: service_healthy | ||
| redis-tls-node-3: | ||
| condition: service_healthy | ||
| redis-tls-node-4: | ||
| condition: service_healthy | ||
| redis-tls-node-5: | ||
| condition: service_healthy | ||
| restart: "no" | ||
| entrypoint: | ||
| - sh | ||
| - -c | ||
| - | | ||
| echo 'Creating Redis TLS Cluster...' && | ||
| redis-cli --cluster create redis-tls-node-0:6380 redis-tls-node-1:6381 redis-tls-node-2:6382 redis-tls-node-3:6383 redis-tls-node-4:6384 redis-tls-node-5:6385 --cluster-replicas 1 --cluster-yes --tls --cert /tls/redis.crt --key /tls/redis.key --cacert /tls/ca.crt && | ||
| echo 'Redis TLS Cluster created successfully' && | ||
| redis-cli -h redis-tls-node-0 -p 6380 --tls --cert /tls/redis.crt --key /tls/redis.key --cacert /tls/ca.crt CLUSTER INFO | ||
|
|
||
| volumes: | ||
| redis-tls-cluster-0: | ||
| redis-tls-cluster-1: | ||
| redis-tls-cluster-2: | ||
| redis-tls-cluster-3: | ||
| redis-tls-cluster-4: | ||
| redis-tls-cluster-5: |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.