armbian-upgrade: use apt-get to silence apt CLI-warning noise

[igorpecovnik]

What

/usr/bin/armbian-upgrade calls plain apt, which prints

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

on every non-interactive invocation — so each upgrade run emits it twice (once for apt update, once for apt -y upgrade), cluttering build logs and user output.

Switch to apt-get, the stable scripting interface, which behaves identically for update / upgrade / clean / autoremove but prints no such warning.

Not addressed here

The separate [ ! ] repository switch returned non-zero line is emitted at runtime (armbian-config repo handling), not by this script — out of scope for this change.

Summary by CodeRabbit

• Bug Fixes
  • Improved system upgrade process reliability and stability by enhancing the underlying upgrade mechanism.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 10e609a6-b44f-4af1-81fa-84df9eff12d6

📥 Commits

Reviewing files that changed from the base of the PR and between 2195f35 and a8c501a.

📒 Files selected for processing (1)

• packages/bsp/common/usr/bin/armbian-upgrade

---

📝 Walkthrough

Walkthrough

The armbian-upgrade script replaces all apt front-end invocations with direct apt-get calls (apt-get update, apt-get -y upgrade, apt-get clean, apt-get -y autoremove) and adds inline comments explaining the choice. The surrounding script structure (root check, trap, exit) is unchanged.

Changes

apt-get migration in armbian-upgrade

Layer / File(s)	Summary
Replace apt with apt-get in upgrade steps packages/bsp/common/usr/bin/armbian-upgrade	The four upgrade operations (update, upgrade, clean, autoremove) are rewritten to call apt-get directly, with comments noting the preference for apt-get in scripts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A hop through the script, a small swap in place,
apt steps aside, apt-get takes the race.
Update, upgrade, clean, autoremove too —
Stable scripting magic, all shiny and new.
The rabbit nods once and bounds off with glee! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing apt with apt-get to eliminate CLI warning messages from the script.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/armbian-upgrade-apt-warning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}