Skip to content

sunxi64: Enable CONFIG_DRM_PANEL_MIPI_DBI=m for current and edge configs#9984

Merged
igorpecovnik merged 2 commits into
armbian:mainfrom
d93921012:patch-1
Jun 19, 2026
Merged

sunxi64: Enable CONFIG_DRM_PANEL_MIPI_DBI=m for current and edge configs#9984
igorpecovnik merged 2 commits into
armbian:mainfrom
d93921012:patch-1

Conversation

@d93921012

@d93921012 d93921012 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

Add CONFIG_DRM_PANEL_MIPI_DBI=m to sunxi64 current and edge kernel configs.

This allows users to utilize standard SPI/MIPI-DBI displays easily out of the box without needing to compile the module manually.

Fixes #9978

How Has This Been Tested?

  • Manually compiled panel-mipi-dbi.ko as an out-of-tree module on an Orange Pi Zero 3 (Kernel 6.18.33-current-sunxi64) and successfully verified that the SPI display lights up and works perfectly with Device Tree Overlays.

Checklist:

  • I have performed a self-review of my own code

Summary by CodeRabbit

  • Improvements
    • Added MIPI DBI display panel driver support for enhanced hardware compatibility across supported device configurations.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 92ba7f7b-80a9-48d0-bd51-8d6d7b897db6

📥 Commits

Reviewing files that changed from the base of the PR and between de8c77b and 5e3b838.

📒 Files selected for processing (2)
  • config/kernel/linux-sunxi64-current.config
  • config/kernel/linux-sunxi64-edge.config

📝 Walkthrough

Walkthrough

Adds CONFIG_DRM_PANEL_MIPI_DBI=m as a single-line change to both linux-sunxi64-current.config and linux-sunxi64-edge.config, enabling the MIPI DBI DRM panel driver as a loadable kernel module for the sunxi64 platform.

Changes

MIPI DBI Panel Driver Config

Layer / File(s) Summary
Enable MIPI DBI panel module in sunxi64 configs
config/kernel/linux-sunxi64-current.config, config/kernel/linux-sunxi64-edge.config
Sets CONFIG_DRM_PANEL_MIPI_DBI=m in both the current and edge sunxi64 kernel defconfigs, enabling the MIPI DBI DRM panel driver as a loadable module.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Hop hop, a module takes flight,
Two config lines set things just right,
MIPI DBI now loads with ease,
Tiny SPI displays lit to please,
The rabbit cheers — what a delight! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially implements the linked issue #9978 by enabling CONFIG_DRM_PANEL_MIPI_DBI=m for current and edge configs, but omits the legacy config file requested in the issue. Add CONFIG_DRM_PANEL_MIPI_DBI=m to config/kernel/linux-sunxi64-legacy.config to fully address issue #9978 requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and clearly describes the main change: enabling CONFIG_DRM_PANEL_MIPI_DBI=m for sunxi64 current and edge kernel configurations.
Out of Scope Changes check ✅ Passed All changes are directly related to enabling the MIPI DBI panel driver for sunxi64 configurations as specified in issue #9978; no out-of-scope changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 08 Milestone: Third quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jun 16, 2026

@EvilOlaf EvilOlaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine

@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Jun 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Jun 16, 2026
@igorpecovnik igorpecovnik merged commit 74f1543 into armbian:main Jun 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

[Feature Request]: sunxi64: Enable CONFIG_DRM_PANEL_MIPI_DBI=m to support SPI/MIPI-DBI displays

3 participants