Skip to content

bananapim5pro: fix u-boot bad magic boot panic on edge branch#9917

Draft
LukaHummel wants to merge 2 commits into
armbian:mainfrom
LukaHummel:rk3576-bananapi-m5-pro-edge-kernel
Draft

bananapim5pro: fix u-boot bad magic boot panic on edge branch#9917
LukaHummel wants to merge 2 commits into
armbian:mainfrom
LukaHummel:rk3576-bananapi-m5-pro-edge-kernel

Conversation

@LukaHummel

Copy link
Copy Markdown

Description

bananapim5pro: fix u-boot bad magic boot panic on edge branch

The current edge target tries to map to a non-existent mainline U-Boot configuration for the Banana Pi M5 Pro, resulting in an empty 0-byte DTB file compilation and an immediate FDT_ERR_BADMAGIC panic at boot. This PR adds an _edge suffix override to gracefully fall back to the validated ArmSoM Sige5 U-Boot configurations exclusively for edge builds.

How Has This Been Tested?

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Added configuration for edge branch to fix U-Boot DTB compilation issue.
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 903df3b0-fbec-4378-abf5-9d1c0dac5778

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release labels May 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hey @LukaHummel! 👋

Thanks for submitting your first pull request to the Armbian project — we're excited to have you contributing! 🧡
Your effort doesn’t just improve Armbian — it benefits the entire community of users and developers.

If you'd like to stay informed about project updates or collaborate more closely with the team,
you can optionally share some personal contact preferences at armbian.com/update-data.
This helps us keep in touch without relying solely on GitHub notifications.

Also, don’t forget to ⭐ star the repo if you haven’t already — and welcome aboard! 🚀

@github-actions github-actions Bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels May 31, 2026
@EvilOlaf EvilOlaf added the Can be closed? Ping developers on stalled issue / PR label Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Can be closed? Ping developers on stalled issue / PR Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants