Fix the potential double delegate call per request#196
Open
DesmanLead wants to merge 1 commit intoarmadsen:masterfrom
Open
Fix the potential double delegate call per request#196DesmanLead wants to merge 1 commit intoarmadsen:masterfrom
DesmanLead wants to merge 1 commit intoarmadsen:masterfrom
Conversation
Author
mbarnach
approved these changes
Nov 3, 2023
mbarnach
left a comment
mbarnach
left a comment
There was a problem hiding this comment.
Awesome! Good finding!!! Thanks for that! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been facing a situation when both
requestDidTimeoutanddidReceiveResponsewere called for a single request. This might result in a crash when used e.g. with DispatchGroups to wait for the request completion.