-
Notifications
You must be signed in to change notification settings - Fork 5
Support for gradle modules not named app
#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
43474b3 to
d86c720
Compare
ariedov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why, but it seems like a bunch of indentation changes. Any chance you could reduce the amount of those?
|
Yes, i noticed that to. I checked against the stylua and it seems to match? Edit: I think it's that the indentation was previously using tabs. My editor changed it to spaces as suggested by the |
|
Maybe revert the indentation changes to simplify the review and issue a new PR that fixes only that? :) |
|
I changed the indentation back to tabs for now. There are still some changes in the indentation style. Looks like it was some mixture beforehand |
|
Still a few hundred lines that are just indentations. I appreciate the contribution, just want it to be more focused. We can discuss indentation issues in another PR. |
|
Sure, I just need to find the time to go over the changes and check which indentation was used before. If it's just about to be more focussed: there is an option to hide whitespace changes in the dropdown from the gear symbol :) |
Hey there,
Great plugin! I just had the issue that I am using a gardle module called
app:)Notable Changes:
findsys-call withvim.fs.findbuild.gradle.ktsis located`-debug.apkfilename to match the gradle modules name.stylua.tomldefinition