Skip to content

Conversation

@Marfien
Copy link

@Marfien Marfien commented Oct 16, 2025

Hey there,

Great plugin! I just had the issue that I am using a gardle module called app :)

Notable Changes:

  • Replace find sys-call with vim.fs.find
  • Replace root occurances with module root (where the build.gradle.kts is located`
  • Adjusted the -debug.apk filename to match the gradle modules name
  • (my editor) reformatted code to match the .stylua.toml definition

Copy link
Owner

@ariedov ariedov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but it seems like a bunch of indentation changes. Any chance you could reduce the amount of those?

@Marfien
Copy link
Author

Marfien commented Oct 17, 2025

Yes, i noticed that to. I checked against the stylua and it seems to match?

Edit: I think it's that the indentation was previously using tabs. My editor changed it to spaces as suggested by the .stylua.toml

@unnamedhorse
Copy link

Maybe revert the indentation changes to simplify the review and issue a new PR that fixes only that? :)

@Marfien
Copy link
Author

Marfien commented Oct 18, 2025

I changed the indentation back to tabs for now. There are still some changes in the indentation style. Looks like it was some mixture beforehand

@ariedov
Copy link
Owner

ariedov commented Oct 18, 2025

Still a few hundred lines that are just indentations. I appreciate the contribution, just want it to be more focused. We can discuss indentation issues in another PR.

@Marfien
Copy link
Author

Marfien commented Oct 18, 2025

Sure, I just need to find the time to go over the changes and check which indentation was used before.

If it's just about to be more focussed: there is an option to hide whitespace changes in the dropdown from the gear symbol :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants