Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft about steps I needed to make TypeScript work.
This is still a WIP, by running the steps as outlined in the PR diff, I'm still facing issues that I need to dig further:
bigintseems to handled incorrectly, I've got diffs likeLock › Deployment › Should receive and store the funds to lock assert.strictEqual(received, expected) Expected value to strictly be equal to: 1000000000 Received: 1000000000nLock › Withdrawals › Validations › Should revert with the right error if called too soon VM Exception while processing transaction: reverted with reason string 'Unlock time should be in the future' at Lock.constructor (contracts/Lock.sol:14).