feat: enhance Gateway API plugin with in-progress label management #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for automatic labeling of Gateway API routes during canary deployments to prevent GitOps drift. - Updated documentation to reflect new features, including the ability to customize or disable the in-progress label. - Improved tests to verify the addition and removal of the in-progress label for HTTP, gRPC, TCP, and TLS routes. This change enhances the integration with GitOps tools like Argo CD, ensuring smoother deployments and better resource management. Signed-off-by: rick.stokkingreef <rick.stokkingreef@airalo.com>
stokkie90
force-pushed
the
label-httproute
branch
from
0f7dc39 to
005b751
Compare
Signed-off-by: rick.stokkingreef <rick.stokkingreef@airalo.com>
Signed-off-by: rick.stokkingreef <rick.stokkingreef@airalo.com>
Signed-off-by: rick.stokkingreef <rick.stokkingreef@airalo.com>
Signed-off-by: rick.stokkingreef <rick.stokkingreef@airalo.com>
kostis-codefresh
requested changes
Dec 5, 2025
Collaborator
kostis-codefresh
left a comment
kostis-codefresh
left a comment
There was a problem hiding this comment.
Many thanks for this.
Can you confirm please that the flaky test suite works ok locally in your workstation?
test/cluster-setup/sanity-check.sh
Outdated
|
|
||
| sleep 10 | ||
|
|
||
| kubectl get gatewayclasses traefik |
Collaborator
There was a problem hiding this comment.
Could you explain why this is needed here? Why do we check twice the same command?
Did something change in the latest Traefik version and it is slower to start up?
Contributor
Author
There was a problem hiding this comment.
I noticed the Condition/Status was not Accepted right away, when this script was triggered (at least locally) a wait for 10 seconds should make it a bit more stable. Migth be related to the updates of the charts and versions
stokkie90
force-pushed
the
label-httproute
branch
from
d1e4a89 to
5bb5308
Compare
stokkie90
commented
Dec 9, 2025
Comment on lines
+399
to
+408
| if managedRouteIndex < 0 || managedRouteIndex >= len(routeRuleList) { | ||
| // stale or corrupted managed route index; clean references for this route and continue gracefully | ||
| for name, managedMap := range managedRouteMap { | ||
| delete(managedMap, httpRouteName) | ||
| if len(managedMap) == 0 { | ||
| delete(managedRouteMap, name) | ||
| } | ||
| } | ||
| return routeRuleList, nil | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I experienced these issues, and only fix was to remove the configmap.
time="2025-12-09T08:47:12Z" level=error msg="roCtx.reconcile err failed to remove managed routes via plugin: RemoveManagedRoutes rpc call error: unexpected EOF" generation=4 namespace=default resourceVersion=15228 rollout=grpcroute-filters-rollout
2025-12-09T08:47:12.365Z [ERROR] plugin: plugin process exited: plugin=/home/argo-rollouts/plugin-bin/argoproj-labs/gatewayAPI id=5252 error="exit status 2"
time="2025-12-09T08:47:12Z" level=info msg="Reconciliation completed" generation=4 namespace=default resourceVersion=15228 rollout=grpcroute-filters-rollout time_ms=216.659584
time="2025-12-09T08:47:12Z" level=error msg="rollout syncHandler error: failed to remove managed routes via plugin: RemoveManagedRoutes rpc call error: unexpected EOF" namespace=default rollout=grpcroute-filters-rollout
time="2025-12-09T08:47:12Z" level=info msg="rollout syncHandler queue retries: 39 : key \"default/grpcroute-filters-rollout\"" namespace=default rollout=grpcroute-filters-rollout
time="2025-12-09T08:47:12Z" level=error msg="failed to remove managed routes via plugin: RemoveManagedRoutes rpc call error: unexpected EOF" error="<nil>"
time="2025-12-09T08:47:22Z" level=info msg="Started syncing rollout" generation=4 namespace=default resourceVersion=15228 rollout=grpcroute-filters-rollout
time="2025-12-09T08:47:22Z" level=info msg="delaying service switch from to 55f5b6b: ReplicaSet not fully available" namespace=default rollout=grpcroute-filters-rollout service=argo-rollouts-canary-service
…maximum of 5 attempts, improving reliability of e2e tests. Signed-off-by: rick.stokkingreef <rick.stokkingreef@airalo.com>
Collaborator
|
I run the flaky tests locally and they pass. This is now available as 0.9.0 both in binaries https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/tag/v0.9.0 and as docker image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhances the integration with GitOps tools like Argo CD, ensuring smoother deployments and better resource management.