Conversation
Member
|
Why the commits should be removed on merge? If the patch cleanly fixes the CI, can we just backport everything here? |
Author
Sorry, just saw this comment. They belong to blocking tickets, and by the time they are done there patches will be on the main branch. |
20.04 is EOL so update the user guide and tests to 22.04. The contributing guide was updated to 22.04 in d55836e. (cherry picked from commit fcd00a4) Changes compared to the original commit: - Remove PostgreSQL 18 from the Ubuntu 22.04 image as it is not supported yet. - Add PostgreSQL 9.4 to the Ubuntu 22.04 image as is still supported. - Remove archive fetching logic for Ubuntu 20.04.
dkovalev1
reviewed
Mar 11, 2026
dkovalev1
reviewed
Mar 11, 2026
dkovalev1
reviewed
Mar 11, 2026
Container hash was invalid, making testing logic think that it is possible to run PostgreSQL 9.4 tests on the cached image.
20.04 is EOL and Docker is now noisy during installation so update. (cherry picked from commit d55836e) Changes compared to the original commit: - Use actual output of the test.pl script
dkovalev1
approved these changes
Mar 11, 2026
bandetto
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update user guide and tests to Ubuntu 22.04
20.04 is EOL so update the user guide and tests to 22.04.
The contributing guide was updated to 22.04 in d55836e.
(cherry picked from commit fcd00a4)
Changes compared to the original commit:
Update container hash for the Ubuntu 22.04 image4)
Container hash was invalid, making testing logic think that it is
possible to run PostgreSQL 9.4 tests on the cached image.
Update contributing guide to Ubuntu 22.04.
20.04 is EOL and Docker is now noisy during installation so update.
(cherry picked from commit d55836e)
Changes compared to the original commit:
Note:
There are main two changes compared to the upstream PR:
messages.
Other changes are listed in the respective commits.
This branch is intended to be merged with rebase.