ADH-8370: [Backport] Support Zookeeper for metastore service discovery#61
Open
SidorovGreg wants to merge 8 commits into
Open
ADH-8370: [Backport] Support Zookeeper for metastore service discovery#61SidorovGreg wants to merge 8 commits into
SidorovGreg wants to merge 8 commits into
Conversation
iamlapa
reviewed
Jun 25, 2026
iamlapa
approved these changes
Jun 26, 2026
ADH-8535: [Backport] Hive2: ZooKeeper SSL/TLS support
werzerbb
reviewed
Jul 6, 2026
| clientConfig.setProperty(ZKClientConfig.ZOOKEEPER_CLIENT_CNXN_SOCKET, | ||
| ClientCnxnSocketNetty.class.getName()); | ||
|
|
||
| ClientX509Util x509Util = new ClientX509Util(); |
There was a problem hiding this comment.
ClientX509Util is Closeable but never closed, it's used without try-with-resources statement here and in ZooKeeperTokenStore.
| } else { | ||
| close(); | ||
| if (isZooKeeperServiceDiscoveryEnabled()) { | ||
| resolveMetastoreUris(); |
There was a problem hiding this comment.
If there are no live metastore servers registered in ZK then MetaException("No metastore service discovered in ZooKeeper. ...") will be thrown without any retry logic during reconnection process.
I think it's worth adding a retry to get metastore list (add new exception type and check it in RetryingMetaStoreClient::invoke).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.