Skip to content

fix: race condition during fast open/close #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arekkubaczkowski merged 1 commit into from
Jan 22, 2026
Merged

fix: race condition during fast open/close #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/BottomSheetBackdrop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import Animated, {
useAnimatedStyle,
} from 'react-native-reanimated';
import { getAnimatedIndex } from './animatedRegistry';
import { useSheetStatus } from './bottomSheet.store';

interface BottomSheetBackdropProps {
sheetId: string;
Expand All @@ -16,9 +15,7 @@ export function BottomSheetBackdrop({
sheetId,
onPress,
}: BottomSheetBackdropProps) {
const status = useSheetStatus(sheetId);
const animatedIndex = getAnimatedIndex(sheetId);
const isInteractive = status === 'open';

const animatedStyle = useAnimatedStyle(() => {
const opacity = interpolate(
Expand All @@ -35,9 +32,7 @@ export function BottomSheetBackdrop({
<Pressable
style={StyleSheet.absoluteFillObject}
onPress={() => {
if (isInteractive) {
onPress?.();
}
onPress?.();
}}
>
<Animated.View
Expand Down
4 changes: 4 additions & 0 deletions src/store/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ export function isHidden(sheet: BottomSheetState | undefined): boolean {
return sheet?.status === 'hidden';
}

export function isOpening(sheet: BottomSheetState | undefined): boolean {
return sheet?.status === 'opening';
}

export function updateSheet(
sheetsById: Record<string, BottomSheetState>,
id: string,
Expand Down
3 changes: 2 additions & 1 deletion src/store/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
getTopSheetId,
isActivatableKeepMounted,
isHidden,
isOpening,
removeFromStack,
updateSheet,
} from './helpers';
Expand Down Expand Up @@ -66,7 +67,7 @@ export const useBottomSheetStore = create(
startClosing: (id) =>
set((state) => {
const sheet = state.sheetsById[id];
if (!sheet || isHidden(sheet)) return state;
if (!sheet || isHidden(sheet) || isOpening(sheet)) return state;

let updatedSheetsById = updateSheet(state.sheetsById, id, {
status: 'closing',
Expand Down
Loading