[update] Add progress status to the update #110
+88
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mirkoCrobu
requested review from
a team,
dido18 and
lucarin91
and removed request for
dido18
dido18
reviewed
Nov 26, 2025
lucarin91
requested changes
Dec 10, 2025
Contributor
lucarin91
left a comment
lucarin91
left a comment
There was a problem hiding this comment.
We should also add a progress to the docker image download step
| data string | ||
| err error // error field for error events | ||
| Type EventType | ||
| Progress float32 |
Contributor
There was a problem hiding this comment.
I would make this private
Suggested change
| Progress float32 | |
| progress float32 |
| func NewProgressEvent(progress float32) Event { | ||
| return Event{ | ||
| Type: ProgressEvent, | ||
| data: fmt.Sprintf("%.2f", progress), |
Contributor
There was a problem hiding this comment.
I would not use data in this case
Suggested change
| data: fmt.Sprintf("%.2f", progress), |
Comment on lines
90
to
93
| func (e Event) GetError() error { | ||
| f.Assert(e.Type == ErrorEvent, "not an error event") | ||
| return e.err | ||
| } |
Contributor
There was a problem hiding this comment.
can you add a GetProgress function?
func (e Event) GetProgress() float32 {
f.Assert(e.Type == ProgressEvent, "not a progress event")
return e.progress
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When launching the update process (both via API and, eventually, a CLI command), we should return a progress in percentage. This could be done in many ways:
estimate the time needed for some tasks, based on previous measurements (for example, how much it usually takes to do an apt update on Imola)
When we know there is a list of tasks to do (a list of packages to update), then it's possible to use that to provide progress information
This information can then be used by the FE team (App Lab) to show a progress bar.
Change description
Additional Notes
Reviewer checklist
main.