fix: Parenthesize implementing type ternaries joined with ||#201
Merged
ardeois merged 1 commit intoMar 23, 2026
Merged
Conversation
lucastraba
force-pushed
the
fix/parenthesize-implementing-types
branch
from
30dc64e to
a366020
Compare
ardeois
approved these changes
Mar 19, 2026
Owner
ardeois
left a comment
ardeois
left a comment
There was a problem hiding this comment.
Looks good !
Thanks for the update
Contributor
Author
Really happy to contribute to this awesome project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
||in thecase 'implement':codepath (src/index.ts), fixing incorrect operator precedence between||and?:useImplementingTypes,useImplementingTypesAndDefaultNullableToNull, anduseImplementingTypesAndTerminateCircularRelationshipsto expect parenthesized outputTest plan
toContainassertions to match new parenthesized outputshould parenthesize implementing types with 3+ implementationswith a dedicated 3-implementor schema (TypeA,TypeB,TypeC)