Fix empty return statements not being emitted in bytecode.#38
Open
BenJilks wants to merge 1 commit intoarcticfox1919:mainfrom
Open
Fix empty return statements not being emitted in bytecode.#38BenJilks wants to merge 1 commit intoarcticfox1919:mainfrom
BenJilks wants to merge 1 commit intoarcticfox1919:mainfrom
Conversation
This patch makes block `retExps` optional. This value being `null` means there was no return statement at the end of the block. It being an empty list, means an empty return statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #34.
To determine if a block has a return statement, it was checking if
retExpsis empty. However, if an empty return statement was given (for example, in the code below), this would also be empty. Meaning theRETURNbytecode was never emitted.This PR makes block
retExpsoptional. This value beingnullmeans there was no return statement at the end of the block. It being an empty list, means an empty return statement.