Skip to content

Conversation

@marc-romu
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings March 30, 2025 17:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses an issue where the version badge was not updating correctly when there was a version mismatch between the README and the version specified in Solution.props.

  • Added debug echo statements to help trace version and badge updates.
  • Modified the logic to extract the current version and status from README badge URLs and added comparison checks to determine if an update is required.
Comments suppressed due to low confidence (2)

.github/actions/version-tools/action.yml:145

  • The use of grep with the -P flag may not be supported in all environments. Consider confirming its compatibility or using an alternative approach to ensure consistent behavior.
CURRENT_VERSION_IN_BADGE=$(echo "$CURRENT_VERSION_BADGE" | grep -oP 'version-\K[^-]*(?=-|-)' | sed 's/%2E/./g' | sed 's/--/-/g')

.github/actions/version-tools/action.yml:169

  • Similar to the version extraction, grep -oP is used here and may cause compatibility issues in some environments. Make sure the target CI environment supports this flag or consider an alternative solution.
CURRENT_STATUS_IN_BADGE=$(echo "$CURRENT_STATUS_BADGE" | grep -oP 'status-\K[^-]*(?=-)')

@marc-romu marc-romu merged commit b29706e into dev Mar 30, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants