release/0.3.2-alpha

.gitattributes

@@ -1,2 +1,7 @@
 # Auto detect text files and perform LF normalization
 * text=auto
+
+# Ensure consistent LF line endings for specific file types
+*.md text eol=lf
+*.ps1 text eol=lf
+*.cs text eol=lf

.github/CODEOWNERS

@@ -18,12 +18,15 @@
 # Critical repository files
 /.gitignore         @marc-romu
 /.gitattributes     @marc-romu
-/.windsurfrules     @marc-romu
+/.windsurf/**       @marc-romu
 *.ps1               @marc-romu
 
 # Critical solution files
 /*.sln              @marc-romu
 /NuGet.Config       @marc-romu
 /Solution.props     @marc-romu
 /Directory.Build.props @marc-romu
-/Directory.Build.targets @marc-romu
+/Directory.Build.targets @marc-romu
+
+# Yak package
+/yak-package/**     @marc-romu

.github/actions/code-style/action.yml

@@ -26,33 +26,44 @@ runs:
       uses: actions/setup-dotnet@v4
       with:
         dotnet-version: '7.0.x'
-    - name: Run dotnet-format
-      shell: bash
-      run: |
-        dotnet restore
-        dotnet tool install -g dotnet-format || true
-        export PATH="$HOME/.dotnet/tools:$PATH"
-        if [ "${{ inputs.mode }}" = "check" ]; then
-          dotnet format --verify-no-changes
-        else
-          dotnet format
-        fi
-    - name: Process C# file headers
+    # - name: Run dotnet-format
+    #   shell: bash
+    #   run: |
+    #     dotnet restore
+    #     dotnet tool install -g dotnet-format || true
+    #     export PATH="$HOME/.dotnet/tools:$PATH"
+    #     if [ "${{ inputs.mode }}" = "check" ]; then
+    #       dotnet format --verify-no-changes
+    #     else
+    #       dotnet format
+    #     fi
+    - id: header
+      name: Process C# file headers
+      continue-on-error: ${{ inputs.mode == 'check' }}
       uses: ./.github/actions/code-style/header-fixer
       with:
         mode: soft-check
-    - name: Process trailing whitespace
+    - id: whitespace
+      name: Process trailing whitespace
+      continue-on-error: ${{ inputs.mode == 'check' }}
       uses: ./.github/actions/code-style/trailing-whitespace
       with:
         mode: ${{ inputs.mode }}
-    - name: Process using directives
+    - id: using_sorter
+      name: Process using directives
+      continue-on-error: ${{ inputs.mode == 'check' }}
       uses: ./.github/actions/code-style/using-sorter
       with:
         mode: ${{ inputs.mode }}
-    - name: Check namespaces
+    - id: namespace_fixer
+      name: Check namespaces
+      continue-on-error: ${{ inputs.mode == 'check' }}
       uses: ./.github/actions/code-style/namespace-fixer
       with:
         mode: soft-check
+    - name: Fail on check errors
+      if: ${{ inputs.mode == 'check' && (steps.header.outcome == 'failure' || steps.whitespace.outcome == 'failure' || steps.using_sorter.outcome == 'failure' || steps.namespace_fixer.outcome == 'failure') }}
+      run: exit 1
     - name: Commit & push changes
       if: ${{ inputs.commit }}
       shell: bash

.github/actions/code-style/header-fixer/action.yml

@@ -4,7 +4,7 @@ inputs:
   mode:
     description: "Operation mode: fix, check, or soft-check"
     required: false
-    default: "soft-check"
+    default: "check"
 runs:
   using: "composite"
   steps:
@@ -14,6 +14,15 @@ runs:
         GITHUB_EVENT_NAME: ${{ github.event_name }}
         GITHUB_EVENT_PATH: ${{ github.event_path }}
       run: |
+        # Set the shell to exit on error
+        set -o errexit -o pipefail
+
+        # Set up error handling
+        trap 'echo "HEADER-FIXER ERR: line $LINENO, cmd: $BASH_COMMAND" >&2' ERR
+
+        # Debug information
+        echo "Header Fixer Debug: mode=${{ inputs.mode }}, event=$GITHUB_EVENT_NAME"
+
         # Determine files to process: changed in PR or all .cs in src/
         if [ "$GITHUB_EVENT_NAME" = "pull_request" ] && [ -f "$GITHUB_EVENT_PATH" ]; then
           BASE_SHA=$(jq -r .pull_request.base.sha < "$GITHUB_EVENT_PATH")
@@ -23,47 +32,125 @@ runs:
           # Fallback to all .cs files under src/
           FILES=$(find src -type f -name '*.cs')
         fi
+
+        # Debug information
+        # echo "DEBUG: Determined files: $FILES"
+        # echo "Files to process: length=${#FILES[@]}"
+
         # If no files, skip
         if [ -z "$FILES" ]; then
           echo "No C# files to process"
           exit 0
         fi
         ERR=0
+        FAILED_FILES=()
         for file in $FILES; do
+          # echo "DEBUG: Processing file: $file"
           if [ -f "$file" ]; then
-            year=$(grep -m1 '^ \* Copyright' "$file" | grep -oE '[0-9]{4}')
+            # Skip auto-generated files
+            if head -n 20 "$file" | grep -q '<auto-generated>'; then
+              echo "Skipping auto-generated file $file"
+              continue
+            fi
+
+            # Get year
+            year=$(grep -m1 '^ \* Copyright' "$file" | grep -oE '[0-9]{4}' || true)
+            # echo "DEBUG: Extracted year=$year for $file"
             [ -z "$year" ] && year=$(date +%Y)
 
-            # Create header template
-            HEADER="/*\n * SmartHopper - AI-powered Grasshopper Plugin\n * Copyright (C) $year Marc Roca Musach\n *\n * This library is free software; you can redistribute it and/or\n * modify it under the terms of the GNU Lesser General Public\n * License as published by the Free Software Foundation; either\n * version 3 of the License, or (at your option) any later version.\n */"
-
-            # Get current header
-            HEADER_LINES=$(echo -e "$HEADER" | wc -l)
-            CURRENT_HEADER=$(head -n $HEADER_LINES "$file")
+            # Header template lines
+            HEADER_LINES_ARRAY=(
+              "/*"
+              " * SmartHopper - AI-powered Grasshopper Plugin"
+              " * Copyright (C) $year Marc Roca Musach"
+              " *"
+              " * This library is free software; you can redistribute it and/or"
+              " * modify it under the terms of the GNU Lesser General Public"
+              " * License as published by the Free Software Foundation; either"
+              " * version 3 of the License, or (at your option) any later version."
+              " */"
+              ""
+            )
+            HEADER_LINE_COUNT=${#HEADER_LINES_ARRAY[@]}
+
+            # Compare header per-line ignoring year
+            # echo "Comparing header for $file"
+            mismatch=0
+            mismatch_line=0
+            for ((i=0; i<HEADER_LINE_COUNT; i++)); do
+              TEMPLATE_LINE=${HEADER_LINES_ARRAY[i]}
+              FILE_LINE=$(sed -n "$((i+1))p" "$file")
+              TEMPLATE_CAN=$(echo "$TEMPLATE_LINE" | sed -E 's/(Copyright \(C\) )[0-9]{4}/\1####/')
+              CURRENT_CAN=$(echo "$FILE_LINE" | sed -E 's/(Copyright \(C\) )[0-9]{4}/\1####/')
+              if [[ "$TEMPLATE_CAN" != "$CURRENT_CAN" ]]; then
+                mismatch=1
+                mismatch_line=$((i+1))
+                break
+              fi
+            done
 
-            if [ "$HEADER" != "$CURRENT_HEADER" ]; then
+            # echo "Header mismatch flag for $file: $mismatch"
+            # Process header mismatch
+            if (( mismatch == 1 )); then
               if [ "${{ inputs.mode }}" = "fix" ]; then
                 echo "Updating header in $file"
-                # Find namespace line
-                NAMESPACE_LINE=$(grep -n '^namespace ' "$file" | head -1 | cut -d: -f1)
-                if [ -n "$NAMESPACE_LINE" ]; then
-                  # Extract content from namespace line to end
-                  CONTENT=$(tail -n +$NAMESPACE_LINE "$file")
-                  # Write new file with correct header
-                  echo -e "$HEADER\n\n$CONTENT" > "$file"
+                echo "DEBUG: mismatch_line=$mismatch_line, HEADER_LINE_COUNT=$HEADER_LINE_COUNT"
+
+                # Read file into array for selective updates
+                readarray -t FILE_CONTENT < "$file"
+                # Determine if full header insertion or line update
+                if [ "$mismatch_line" -eq 1 ]; then
+                  echo "DEBUG: Full header missing, inserting full header"
+                  NEW_HEADER=$(printf "%s\n" "${HEADER_LINES_ARRAY[@]}")
+                  printf "%s\n\n" "$NEW_HEADER" > "$file"
+                  printf "%s\n" "${FILE_CONTENT[@]}" >> "$file"
                 else
-                  echo "Warning: Could not find namespace line in $file"
+                  TEMPLATE_LINE="${HEADER_LINES_ARRAY[$((mismatch_line-1))]}"
+                  echo "DEBUG: Replacing header line $mismatch_line with: $TEMPLATE_LINE"
+                  FILE_CONTENT[$((mismatch_line-1))]="$TEMPLATE_LINE"
+                  printf "%s\n" "${FILE_CONTENT[@]}" > "$file"
                 fi
-              else
-                if [ "${{ inputs.mode }}" = "soft-check" ]; then
-                  # emit a non-blocking warning
-                  echo "::warning file=$file::Header mismatch in $file (run with mode=fix to auto-fix)"
-                else
-                  echo "Header mismatch in $file"
-                  ERR=1
+
+                # Check and fix unbalanced comment blocks in first 20 lines
+                HEAD_LINES=$(head -n 20 "$file")
+                OPEN_COUNT=$(grep -o '/\*' <<<"$HEAD_LINES" | wc -l || true)
+                CLOSE_COUNT=$(grep -o '\*/' <<<"$HEAD_LINES" | wc -l || true)
+                echo "DEBUG: OPEN_COUNT=$OPEN_COUNT, CLOSE_COUNT=$CLOSE_COUNT in first 20 lines"
+                if [ "$OPEN_COUNT" -ne "$CLOSE_COUNT" ]; then
+                  echo "DEBUG: Unbalanced comments in header area, fixing"
+                  if [ "$OPEN_COUNT" -lt "$CLOSE_COUNT" ]; then
+                    # Add missing /* before first comment line
+                    awk 'NR <= 20 && /^[[:space:]]*\*/ && !x {print "/*"; x=1}1' "$file" > "${file}.tmp" && mv "${file}.tmp" "$file"
+                  else
+                    # Add missing */ after last comment line
+                    awk 'NR <= 20 && /\*\// && !x {print; print "*/"; x=1; next}1' "$file" > "${file}.tmp" && mv "${file}.tmp" "$file"
+                  fi
                 fi
+
+              elif [ "${{ inputs.mode }}" = "soft-check" ]; then
+                # emit a non-blocking warning
+                echo "::warning file=$file::Header mismatch in $file (run with mode=fix to auto-fix)"
+
+              elif [ "${{ inputs.mode }}" = "check" ]; then
+                # Emit error annotation and collect failure
+                echo "::error file=$file,line=$mismatch_line::Header mismatch in $file"
+                FAILED_FILES+=("$file:$mismatch_line")
+                ERR=1
               fi
             fi
           fi
         done
+
+        # Summarize failures in check mode
+        if [ "${{ inputs.mode }}" = "check" ] && [ ${#FAILED_FILES[@]} -ne 0 ]; then
+          echo " Header validation failed for the following files (file:line):"
+          for entry in "${FAILED_FILES[@]}"; do
+            path=${entry%%:*}
+            ln=${entry##*:}
+            echo "  - $path (line $ln)"
+          done
+          echo "Run with mode=fix to automatically update headers"
+        elif [ "${{ inputs.mode }}" = "check" ]; then
+          echo " All header validations passed"
+        fi
         exit $ERR

.github/actions/code-style/namespace-fixer/action.yml

@@ -12,6 +12,10 @@ runs:
       if: always()
       shell: bash
       run: |
+        # Set the shell to continue on error
+        set +e
+
+        # Get the list of changed files
         if [ -n "${{ github.event.pull_request }}" ]; then
           FILES=$(git diff --name-only "${{ github.event.pull_request.base.sha }}" "${{ github.event.pull_request.head.sha }}" -- '*.cs')
         else
@@ -38,7 +42,7 @@ runs:
                   # emit a non-blocking warning
                   echo "::warning file=$file::Namespace mismatch in $file (run with mode=fix to auto-fix)"
                 else
-                  echo "Namespace mismatch in $file: expected $ns but found $actual"
+                  echo "::error file=$file::Namespace mismatch in $file: expected $ns but found $actual"
                   ERR=1
                 fi
               fi

.github/actions/code-style/trailing-whitespace/action.yml

@@ -11,24 +11,45 @@ runs:
     - name: Process trailing whitespace
       shell: bash
       run: |
-        FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }})
+        # Set the shell to continue on error
+        set +e
+
+        # Get the list of changed files
+        FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} | grep -v -e '^\.' -e '/\.')
+
+        # Initialize error code
         ERR=0
+
+        # Process each file
         for file in $FILES; do
           if [[ -f "$file" ]]; then
             if [[ "${{ inputs.mode }}" == "fix" ]]; then
               sed -i 's/[ \t]*$//' "$file"
               # normalize to unix line endings
               sed -i 's/\r$//' "$file"
             else
-              if grep -qE '[ \t]+$' "$file" || file "$file" | grep -q CRLF; then
-                if [ "${{ inputs.mode }}" = "soft-check" ]; then
-                  # emit a non-blocking warning
-                  echo "::warning file=$file::Trailing whitespace or CRLF found in $file (run with mode=fix to auto-fix)"
+              # Report trailing whitespace
+              while IFS= read -r entry; do
+                path="${entry%%:*}"
+                num="${entry#*:}"
+                if [[ "${{ inputs.mode }}" == "soft-check" ]]; then
+                  echo "::warning file=$path,line=$num::Trailing whitespace found"
                 else
-                  echo "Trailing whitespace or CRLF found in $file"
+                  echo "::error file=$path,line=$num::Trailing whitespace found"
                   ERR=1
                 fi
-              fi
+              done < <(grep -nE '[[:blank:]]$' "$file" || true)
+              # # Report CRLF
+              # while IFS= read -r entry; do
+              #   path="${entry%%:*}"
+              #   num="${entry#*:}"
+              #   if [[ "${{ inputs.mode }}" == "soft-check" ]]; then
+              #     echo "::warning file=$path,line=$num::CRLF found in $file:$num"
+              #   else
+              #     echo "::error file=$path,line=$num::CRLF found in $file:$num"
+              #     ERR=1
+              #   fi
+              # done < <(grep -n $'\\r$' "$file" || true)
             fi
           fi
         done

.github/actions/code-style/using-sorter/action.yml

@@ -27,16 +27,46 @@ runs:
       run: |
         FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- '*.cs')
         ERR=0
-        dotnet tool install -g dotnet-format || true
-        export PATH="$HOME/.dotnet/tools:$PATH"
+
+        # Function to find the nearest project or solution file
+        find_project_file() {
+          local dir="$(dirname "$1")"
+          local project_file
+
+          while [ "$dir" != "/" ] && [ "$dir" != "." ]; do
+            project_file=$(find "$dir" -maxdepth 1 -type f \( -name '*.csproj' -o -name '*.sln' \) | head -n 1)
+            if [ -n "$project_file" ]; then
+              echo "$project_file"
+              return 0
+            fi
+            dir="$(dirname "$dir")"
+          done
+          return 1
+        }
+
+        # Process each file
         for file in $FILES; do
-          if [ -f "$file" ]; then
-            if [ "${{ inputs.mode }}" = "check" ] || [ "${{ inputs.mode }}" = "soft-check" ]; then
-              dotnet format "$file" --verify-no-changes --fix-analyzers
+          if [[ -f "$file" ]]; then
+            project_file=$(find_project_file "$file")
+            if [ $? -ne 0 ]; then
+              echo "::warning file=$file::Could not find project or solution file for $file"
+              continue
+            fi
+
+            if [[ "${{ inputs.mode }}" == "fix" ]]; then
+              dotnet format style --diagnostics IDE0005 SA1208 SA1210 --include "$file" "$project_file"
             else
-              dotnet format "$file" --fix-analyzers
+              dotnet format style --diagnostics IDE0005 SA1208 SA1210 --include "$file" "$project_file" --verify-no-changes
+              CODE=$?
+              if [ $CODE -ne 0 ]; then
+                if [ "${{ inputs.mode }}" = "soft-check" ]; then
+                  echo "::warning file=$file::Using sorter found issues in $file (run with mode=fix to auto-fix)"
+                else
+                  echo "Using sorter check failed in $file"
+                  ERR=1
+                fi
+              fi
             fi
           fi
         done
-        # fail if any check error
         exit $ERR