UPDATE DEV FROM MAIN #199
Merged
UPDATE DEV FROM MAIN #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixes (#197) This PR prepares the release for version 0.3.1-alpha with version update and code style fixes:\n\n- Fixed header code style\n- Sorted usings\n- Removed trailing whitespace\n- Updated version in Solution.props\n- Updated changelog with closed-solved issues\n- Updated README badges\n\nMILESTONE DESCRIPTION:\n
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the development branch from main by enhancing multiple GitHub workflows and actions. Key changes include:
- Introducing a .NET SDK installation check step across several workflows to conditionally install the SDK.
- Expanding manual dispatch inputs and conditions for creating pull requests.
- Updating several code style actions to support a new "soft-check" mode.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/release-4-build.yml | Added a conditional .NET SDK setup step using a pre-check. |
| .github/workflows/release-3-pr-to-main-closed.yml | Updated PR creation conditions to support manual dispatch. |
| .github/workflows/release-2-pr-to-dev-closed.yml | Added manual dispatch inputs for creating PRs and updated conditional checks. |
| .github/workflows/release-1-milestone.yml | Enhanced release branch management and switched PR creation to use gh pr create. |
| .github/workflows/ci-dotnet-tests.yml | Refactored .NET SDK installation step with a pre-check condition. |
| .github/actions/code-style/* (using-sorter, trailing-whitespace, namespace-fixer, header-fixer, action.yml) | Updated code style actions to include a "soft-check" mode and streamline header and namespace fixes. |
|
|
||
| - name: Setup .NET SDK | ||
| uses: actions/setup-dotnet@v3 | ||
| - name: Check for existing .NET SDK |
There was a problem hiding this comment.
The logic for checking the existing .NET SDK appears in multiple workflow files; consider extracting this logic into a shared composite action to reduce duplication and simplify maintenance.
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Check for existing .NET SDK |
There was a problem hiding this comment.
This .NET SDK version check is repeated across several code style actions; refactoring it into a centralized reusable action could improve maintainability and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.