update dev #158
Merged
update dev #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub workflow for updating branches and adds a new workflow for auto-deleting branches when a PR is closed.
- Updated the user-update-branch workflow to support multiple target branches via a JSON array and introduced a matrix strategy.
- Modified branch checkout, error messages, and PR creation logic to leverage the new matrix variable.
- Added a new workflow to delete auto-generated branches on pull request closure.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/user-update-branch.yml | Refactored to read multiple target branches using a matrix and updated messages and PR creation conditions. |
| .github/workflows/pr-delete-auto-branches.yml | New workflow to auto-delete branches when a matching pull request is closed. |
|
|
||
| - name: Create PR if conflicts or protected branch | ||
| if: steps.attempt-merge.outputs.merge_status == 'conflict' || steps.push-changes.outputs.push_status == 'failed' | ||
| if: steps.attempt-merge.outcome == 'failure' || steps.attempt-merge.outputs.merge_status == 'conflict' || steps.attempt-merge.outputs.merge_status == 'success' |
There was a problem hiding this comment.
Including 'merge_status' equal to 'success' in the condition for creating a PR could lead to unnecessary PRs when a merge successfully occurs. Consider removing this case so that a PR is created only when the merge fails or there is a conflict.
Suggested change
| if: steps.attempt-merge.outcome == 'failure' || steps.attempt-merge.outputs.merge_status == 'conflict' || steps.attempt-merge.outputs.merge_status == 'success' | |
| if: steps.attempt-merge.outcome == 'failure' || steps.attempt-merge.outputs.merge_status == 'conflict' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.